The Wayback Machine - https://web.archive.org/web/20211016043929/https://github.com/MaterialDesignInXAML/MaterialDesignInXamlToolkit/issues/1939
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selected Item in Combobox is removed from the list #1939

Closed
TFTomSun opened this issue Jun 22, 2020 · 6 comments
Closed

Selected Item in Combobox is removed from the list #1939

TFTomSun opened this issue Jun 22, 2020 · 6 comments
Labels
enhancement good first issue Hacktoberfest up-for-grabs
Milestone
4.3.0

Comments

@TFTomSun
Copy link

@TFTomSun TFTomSun commented Jun 22, 2020

While this behavior might be useful for single selection comboboxes, it is an unexpected behavior, when you template the combobox items to achieve a multiselection behavior. Is it possible to disable the behavior that the selected item is removed from the available items list?
@bombipappoo
Copy link
Contributor

@bombipappoo bombipappoo commented Jun 23, 2020

Set ComboBoxAssist.ShowSelectedItem to true, the selected item is shown.
@Keboo
Copy link
Member

@Keboo Keboo commented Jun 30, 2020

It appears that the last specification has changed such that the default is to always show all items in the list. https://material.io/components/menus#exposed-dropdown-menu
@jizc
Copy link
Contributor

@jizc jizc commented Jan 2, 2021

I think it would be a good idea to change the default to show the selected item. It could be added as a "breaking" change in the 4.0.0 release.

Anecdotally I have already had to make this change is our application, because our users were often confused by not seeing the selected item in the dropdown list.
@Keboo
Copy link
Member

@Keboo Keboo commented Jan 4, 2021

@jizc I agree, I think changing the default as part of 4.0.0 makes sense.
@guptaanmol184
Copy link
Contributor

@guptaanmol184 guptaanmol184 commented Oct 6, 2021 •
edited

Hi @Keboo,

I see that 4.0.0 is already released and the current latest release is 4.2.1. If this enhancement is still being considered as a required change for future releases, I would like to help and contribute for implementing the change.
@Keboo
Copy link
Member

@Keboo Keboo commented Oct 6, 2021

Hi @guptaanmol184 yes if you would like to work on this that would be great. Given that simply changing the default would just be a visually breaking change, I would likely just document it as such and put it in the next release.
@guptaanmol184 guptaanmol184 mentioned this issue Oct 6, 2021
Merged
@Keboo Keboo added this to the 4.3.0 milestone Oct 7, 2021
@Keboo Keboo closed this in #2459 Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue Hacktoberfest up-for-grabs
5 participants
@Keboo @jizc @TFTomSun @guptaanmol184 @bombipappoo