Next/experimental release versions include commit date #21700
Merged
+62
−27
Conversation
bvaughn
changed the title
|
Comparing: d7dce57...68053d9 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
bvaughn
changed the title
|
Seems unfortunate that our version number logic is split between "scripts/release" and "scripts/rollup". |
|
Not totally opposed, but let's discuss at next team meeting before merging |
|
If we do decide to merge this, I would put the date at the end of the string instead of the middle so that it can't be matched by a ^ or ~. |
|
Actually it seems like there's enough consensus on the team that if you put the date at the end, we can go ahead and merge it |
|
Let's be sure to update any references on the website to the new formatting, e.g. https://reactjs.org/docs/release-channels.html#experimental-channel |
|
And the workgroup post: reactwg/react-18#9 |
|
Weird. The CI failure looks like it's from the previous version of the build file. It doesn't have the changes I pushed. Hmm.
I'll try pushing again. |
bvaughn
force-pushed the
bvaughn:next-experimental-release-versions
branch
from
f0776fd
to
ab7e1e7
Change format of @next and @experimental release versions from <number>-<sha> to <number>-<sha>-<date> to make them more human readable.
bvaughn
force-pushed the
bvaughn:next-experimental-release-versions
branch
from
b30372a
to
68053d9
bvaughn
merged commit 355591a
into
facebook:master
34 checks passed
34 checks passed
ci/circleci: yarn_test--r=stable --env=development --persistent
Your tests passed on CircleCI!
Details
ci/circleci: yarn_test--r=www-classic --env=development --variant=false
Your tests passed on CircleCI!
Details
ci/circleci: yarn_test--r=www-classic --env=development --variant=true
Your tests passed on CircleCI!
Details
ci/circleci: yarn_test--r=www-classic --env=production --variant=false
Your tests passed on CircleCI!
Details
ci/circleci: yarn_test--r=www-classic --env=production --variant=true
Your tests passed on CircleCI!
Details
ci/circleci: yarn_test--r=www-modern --env=development --variant=false
Your tests passed on CircleCI!
Details
ci/circleci: yarn_test--r=www-modern --env=development --variant=true
Your tests passed on CircleCI!
Details
ci/circleci: yarn_test--r=www-modern --env=production --variant=false
Your tests passed on CircleCI!
Details
ci/circleci: yarn_test--r=www-modern --env=production --variant=true
Your tests passed on CircleCI!
Details
ci/circleci: yarn_test_build---project=devtools -r=experimental
Your tests passed on CircleCI!
Details
ci/circleci: yarn_test_build--r=experimental --env=development
Your tests passed on CircleCI!
Details
ci/circleci: yarn_test_build--r=experimental --env=production
Your tests passed on CircleCI!
Details
bvaughn
added a commit
to bvaughn/reactjs.org
that referenced
this pull request
Jun 23, 2021
To account for changes made in PR facebook/react/pull/21700
bvaughn
added a commit
to reactjs/reactjs.org
that referenced
this pull request
Jun 23, 2021
To account for changes made in PR facebook/react/pull/21700
facebook-github-bot
added a commit
to facebookexperimental/Recoil
that referenced
this pull request
Jun 27, 2021
Summary: Includes a re-implementation of the `act` testing API to decouple it from the mock Scheduler module. Because our Jest configuration mocks the Scheduler for all tests in www, some tests had become accidentally coupled to it. I had to update ~60 test files. The most common pattern I found was people calling `act()` with a no-op function, which had the effect of flushing all pending work. This no longer works in the new implementation. (We will eventually provide a way to opt into Scheduler mocking for advanced cases, but it probably won't be the default.) The fix was usually to wrap an earlier update in `act` to ensure that all its work is fully flushed. --- This sync includes the following changes: - **[27c9c95e2](facebook/react@27c9c95: act: Bypass microtask for "default sync" updates ([#21740](facebook/react#21740)) //<Andrew Clark>// - **[e577bfb1c](facebook/react@e577bfb: Add tests for invokeGuardedCallback ([#21734](facebook/react#21734)) //<Dan Abramov>// - **[355591add](facebook/react@355591a: Next/experimental release versions include commit date ([#21700](facebook/react#21700)) //<Brian Vaughn>// - **[d7dce572c](facebook/react@d7dce57: Remove internal `act` builds from public modules ([#21721](facebook/react#21721)) //<Andrew Clark>// - **[06f7b4f43](facebook/react@06f7b4f: `act` should work without mock Scheduler ([#21714](facebook/react#21714)) //<Andrew Clark>// - **[422e0bb36](facebook/react@422e0bb: Delete test-utils implementation of `act` ([#21703](facebook/react#21703)) //<Andrew Clark>// Reviewed By: rickhanlonii Differential Revision: D29314763 fbshipit-source-id: 6c53a053e00defee0ab89f30e2f6bd2a1ff29bce
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Change format of @next and @experimental release versions from
<number>-<sha>to<number>-<sha>-<date>to make them more human readable. This format still preserves the ability for us to easily map a version number to the changes it contains, while also being able to more easily know at a glance how recent a release is.Note that the date used is the date of the commit (not the current date).
scripts/release/build-release-locally.js) and verify version number in packages contains the date of the commit (e.g.0.0.0-68053d940-20210623) and the version embedded as theReactVersionconst does as well (e.g.17.0.3-68053d940-20210623).scripts/release/prepare-release-from-ci.js) and verify version number in packages contains the date of the commit (0.0.0-68053d940-20210623or0.0.0-experimental-68053d940-20210623).