The Wayback Machine - https://web.archive.org/web/20210715055613/https://github.com/flutter/gallery/pull/508
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply upcoming flutter lints #508

Merged
merged 5 commits into from May 25, 2021
Merged

Apply upcoming flutter lints #508

merged 5 commits into from May 25, 2021

Conversation

@guidezpl
Copy link
Member

@guidezpl guidezpl commented May 25, 2021

Apply most upcoming lints from https://flutter.dev/docs/release/breaking-changes/flutter-lints-package, but still rely on pedantic (can only include 1 in analysis_options.yaml)

consts over final, const constructors with Key, replacing unnecessary Containers with SizedBox, string interpolation, debug printing, subclass parameter naming

@rami-a
rami-a approved these changes May 25, 2021
@@ -22,7 +23,7 @@ final valueList = <String>[
/// Tests that the Gallery web benchmarks are run and reported correctly.
Future<void> main() async {
test('Can run a web benchmark', () async {
print('Starting web benchmark tests ...');
stdout.writeln('Starting web benchmark tests ...');

This comment has been minimized.

@rami-a

rami-a May 25, 2021
Member

These changes seem odd, any idea why they happened?

This comment has been minimized.

@guidezpl guidezpl merged commit 85feebc into master May 25, 2021
7 checks passed
7 checks passed
@github-actions
Unit tests on ubuntu-18.04
Details
@github-actions
Unit tests on windows-2019
Details
@github-actions
Unit tests on macos-10.15
Details
@github-actions
Benchmark tests
Details
@github-actions
Golden tests
Details
@wip
WIP Ready for review
Details
@google-cla
cla/google All necessary CLAs are signed
@guidezpl guidezpl deleted the lints branch May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants