Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRefactor vault.py #90
Open
Assignees
Labels
Comments
|
@mzfr I was thinking about the same issue. I think it is a great idea, it will also be more easier to configure Travis later on. |
|
Hi, found this in KWOC. Would like to try to refactor it. But need some context on how to group functions (like which functions can be grouped into a module and then be imported into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, we have around 1200 lines of code in a single file which is probably not a good practice. Also, this will increase since we are going to continue to add more functions. So it would be good if we can move the functions out of the
vault.pyfile and only keep it as an entry point and maybe perform basic checks on ip/url.To call other functions we can have maybe a
utildirectory where we can keep all the existing functions. This will increase the number of imports or number of files but it will definitely help us to keep everything clean in vault.py