The Wayback Machine - https://web.archive.org/web/20211015174033/https://github.com/github/gh-ost/pull/994
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated go-mysql library #994

Merged
merged 2 commits into from Jul 15, 2021
Merged

Replace deprecated go-mysql library #994

merged 2 commits into from Jul 15, 2021

Conversation

@timvaillancourt
Copy link
Contributor

@timvaillancourt timvaillancourt commented Jun 24, 2021

Description

This PR replaces the deprecated github.com/siddontang/go-mysql library with it's replacement github.com/go-mysql-org/go-mysql

In case this PR introduced Go code changes:

  • contributed code is using same conventions as original code
  • script/cibuild returns with no formatting errors, build errors or unit test errors.
@timvaillancourt
Replace deprecated go-mysql library
9d29e8f
@timvaillancourt timvaillancourt mentioned this pull request Jun 24, 2021
Closed
2 tasks
@timvaillancourt timvaillancourt temporarily deployed to production/mysql_role=ghost_testing Jun 24, 2021 Inactive
@timvaillancourt timvaillancourt temporarily deployed to production/mysql_role=ghost_testing Jun 24, 2021 Inactive
@timvaillancourt timvaillancourt added this to the v1.1.3 milestone Jun 24, 2021
@timvaillancourt
Merge branch 'master' into go-mysql-org/go-mysql
a6a7d4c
@timvaillancourt timvaillancourt temporarily deployed to production/mysql_role=ghost_testing Jul 14, 2021 Inactive
gtowey
gtowey approved these changes Jul 15, 2021
View changes
@timvaillancourt timvaillancourt merged commit 732a064 into master Jul 15, 2021
7 checks passed
@timvaillancourt timvaillancourt deleted the go-mysql-org/go-mysql branch Jul 15, 2021
timvaillancourt added a commit that referenced this issue Sep 9, 2021
@timvaillancourt
Revert to before #994
c643b53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement
2 participants
@timvaillancourt @gtowey