The Wayback Machine - https://web.archive.org/web/20220409004016/https://github.com/sayanarijit/xplr/issues/263
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation #263

Open
sayanarijit opened this issue Jun 21, 2021 · 17 comments · Fixed by #268
Open

Improve documentation #263

sayanarijit opened this issue Jun 21, 2021 · 17 comments · Fixed by #268
Labels
good first issue help wanted

Comments

@sayanarijit
Copy link
Owner

@sayanarijit sayanarijit commented Jun 21, 2021

xplr is getting stable. Let's start the exticing stuff... Extensive Documention.

Thanks to Brodie for the push.

@sayanarijit
Copy link
Owner Author

@sayanarijit sayanarijit commented Jun 21, 2021

Include #258 (comment)

@sayanarijit
Copy link
Owner Author

@sayanarijit sayanarijit commented Jun 21, 2021

Also document the fifo based previewer.

@sayanarijit
Copy link
Owner Author

@sayanarijit sayanarijit commented Jun 23, 2021

Still WIP.

@sayanarijit sayanarijit reopened this Jun 23, 2021
@sayanarijit
Copy link
Owner Author

@sayanarijit sayanarijit commented Jun 23, 2021

Moved major parts of the Wiki to https://arijitbasu.in/xplr/en/.

Still a lot to do.

@sayanarijit sayanarijit added good first issue help wanted labels Jun 23, 2021
@tobihans
Copy link
Contributor

@tobihans tobihans commented Oct 12, 2021

Hello👋! I'd like to work on this. Can you give me directives on how to do that?

@sayanarijit
Copy link
Owner Author

@sayanarijit sayanarijit commented Oct 12, 2021

Hey @tobihans thanks for your interest in this project. Pls let me know which OS do you use and give me some time to write the instructions for you.

@tobihans
Copy link
Contributor

@tobihans tobihans commented Oct 12, 2021

Okay, I have a 64bits machine powered by Manjaro Linux.

@sayanarijit
Copy link
Owner Author

@sayanarijit sayanarijit commented Oct 12, 2021

Okay, I have a 64bits machine powered by Manjaro Linux.

Same as me :) I'm on Manjaro + KDE + KWin

Instructions

So, first, I'd read some existing docs to get a feel of how the docs are structured. Then go inside the docs directory, run mdbook serve --open and search for TODO.

➜  src git:(main) grep TODO *
filtering.md:TODO: document each
general-config.md:TODO: Continue documentation.
layouts.md:TODO: document each constraint.
message.md:[TODO][66]
sorting.md:TODO: document each
SUMMARY.md:- [TODO][21]
todo.md:TODO

(Ignore the SUMMARY.md & TODO.md files)

Then visit src/init.lua to find the configuration options that are not covered in the docs. I was documenting from top to bottom, before giving up and sticking TODOs.

So, for each field in the config file, we need to write the heading, describe briefly what it does, and describe the type.

To know the type of each field, refer to the crate documentation.

If it gets too difficult to document the type of a field, just link to the crate doc and move on to the next field. We can always revisit it to find fields linking to the Rust doc and convert them to Lua.

@sayanarijit
Copy link
Owner Author

@sayanarijit sayanarijit commented Oct 12, 2021

NOTE: If you see a Rust type Option<String>, in Lua it'd be nullable string.

@tobihans
Copy link
Contributor

@tobihans tobihans commented Oct 12, 2021

Okay, I understand. Thanks!

@sayanarijit
Copy link
Owner Author

@sayanarijit sayanarijit commented Oct 16, 2021

Top-level config has been fully documented in #357, thanks to @tobihans.

@sayanarijit
Copy link
Owner Author

@sayanarijit sayanarijit commented Nov 1, 2021

Still some TODOs left. We should be able to close it soon.

@tobihans
Copy link
Contributor

@tobihans tobihans commented Nov 1, 2021

Hey, yes there is some remaining work. I was busy due to school, I'll try my best to finish it ASAP.

@sayanarijit
Copy link
Owner Author

@sayanarijit sayanarijit commented Nov 1, 2021

@tobihans no worries, study & personal time comes first. I posted the update primarily to remind myself so that I don't get anxious when I revisit old issues.

@tobihans
Copy link
Contributor

@tobihans tobihans commented Nov 1, 2021

Okay, I understand, thanks.

@techdragon
Copy link

@techdragon techdragon commented Mar 3, 2022

Just a suggestion, the "how do I use this" documentation is kind of lacking. You're documenting how to configure it and all the Lua internals... when coming to this as an existing user of ranger no stranger to text based file managers or vim style modal tools... I couldn't work out how to get it to do basic stuff like select a bunch of files then "copy and paste"/move them to another directory. So far the only basic operation I was able to intuitively master was multiple selection and then deletion. The help is... not great... since it just says I should be able to just use "m" once I'm in the action mode but that doesn't seem to work, so off I go to look for documentation to make sure I'm using it correctly, and ... I've got nothing. No "how to use" documentation for basic operations at all.

@sayanarijit
Copy link
Owner Author

@sayanarijit sayanarijit commented Mar 3, 2022

Hey, @techdragon thanks for the valuable feedback. However, I think the basic "how do I use this" guides would be more effective in video format instead of text, since it's a lot of content and writing/reading would be very time-consuming.

But, since it's a relatively new project, so far we got only one video introducing xplr which does cover copying and moving files (should we link it in the docs too?), and I hope there will be more videos soon.

(my voice and accent is horrible, so I can't really make great videos explaining stuff)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue help wanted
3 participants