The Wayback Machine - https://web.archive.org/web/20210705174615/https://github.com/apache/shardingsphere/issues/10992
Skip to content

/ shardingsphere

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test for shardingsphere-sql-parser-engine #10992

Open
3 tasks
soulasuna opened this issue Jun 24, 2021 · 5 comments
Open
3 tasks

Add unit test for shardingsphere-sql-parser-engine #10992

soulasuna opened this issue Jun 24, 2021 · 5 comments
Assignees
@zzq1314zll
Labels
good first issue in: test project: OSD2021
Milestone
5.0.0-RC1

Comments

@soulasuna
Copy link
Task lists! Give feedback
Contributor

@soulasuna soulasuna commented Jun 24, 2021

Hi community,

This issue is for #10887.

Aim

Add unit test for shardingsphere-sql-parser-engine project to test its public functions.

Basic Qualifications

  • Java
  • Maven
  • Junit.Test

Classes

Add unit test for classes to test its public functions.

  • SQLParserEngine
  • SQLVisitorEngine
  • SQLParserFactory

Examples FYI

  • SQLParserEngineTest
@strongduanmu strongduanmu added this to the 5.0.0-RC1 milestone Jun 24, 2021
@zzq1314zll
Copy link
Contributor

@zzq1314zll zzq1314zll commented Jul 2, 2021

Hi! @strongduanmu I want this issue to be my "virgin commit"
@strongduanmu
Copy link
Member

@strongduanmu strongduanmu commented Jul 2, 2021

@zzq1314zll Welcome to join the SS community.
zzq1314zll added a commit to zzq1314zll/shardingsphere that referenced this issue Jul 2, 2021
@zzq1314zll
[ISSUE #apache#10992] Add unit test for SQLParserEngine
642eaf7
@zzq1314zll zzq1314zll mentioned this issue Jul 2, 2021
Merged
2 of 3 tasks
zzq1314zll added a commit to zzq1314zll/shardingsphere that referenced this issue Jul 2, 2021
@zzq1314zll
[ISSUE #apache#10992] Perfect SQLParserEngine
c0abdb6
@tristaZero
Copy link
Contributor

@tristaZero tristaZero commented Jul 2, 2021

@zzq1314zll aha, welcome, How to raise a PR for your virgin PR.
@zzq1314zll
Copy link
Contributor

@zzq1314zll zzq1314zll commented Jul 2, 2021

@tristaZero I have some questions, can you help me
@zzq1314zll
Copy link
Contributor

@zzq1314zll zzq1314zll commented Jul 2, 2021

image
zzq1314zll added a commit to zzq1314zll/shardingsphere that referenced this issue Jul 2, 2021
@zzq1314zll
[ISSUE #apache#10992] Modify the extra blank lines. delete annotations.
af013ec
zzq1314zll added a commit to zzq1314zll/shardingsphere that referenced this issue Jul 2, 2021
@zzq1314zll
[ISSUE #apache#10992] Format code.
2905d35
zzq1314zll added a commit to zzq1314zll/shardingsphere that referenced this issue Jul 2, 2021
@zzq1314zll
[ISSUE apache#10992] Add unit test for SQLParserFactoryTest
28538bd
tristaZero pushed a commit that referenced this issue Jul 5, 2021
@zzq1314zll
[ISSUE #10992] Add unit test for shardingsphere-sql-parser-engine (#1…
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
542fbab 
…1107)

* [ISSUE ##10992] Add unit test for SQLParserEngine

* [ISSUE ##10992] Perfect SQLParserEngine

* [ISSUE ##10992] Modify the extra blank lines. delete annotations.

* [ISSUE ##10992] Format code.

* [ISSUE #10992] Add unit test for SQLParserFactoryTest

* Define test classes as final classes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue in: test project: OSD2021
4 participants
@strongduanmu @tristaZero @soulasuna @zzq1314zll