The Wayback Machine - https://web.archive.org/web/20201209020914/https://github.com/ThreeMammals/Ocelot/issues/495
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitoring - can we support zipkin or jaeger? #495

Open
tungphuong opened this issue Jul 24, 2018 · 16 comments
Open

Monitoring - can we support zipkin or jaeger? #495

tungphuong opened this issue Jul 24, 2018 · 16 comments

Comments

@tungphuong
Copy link

@tungphuong tungphuong commented Jul 24, 2018

HI,

About tracing feature, can we integrate to zipkin or jaeger? Becase Butterfly is still preview version, we cannot use it for production.

Thanks,

@TomPallister
Copy link
Member

@TomPallister TomPallister commented Jul 25, 2018

@tungphuong Ocelot doesnt support zipkin at the moment, you could probably inject middleware or use delegating handlers to add this to Ocelot. I will leave this issue open and look into if we could provide easy integration with zipkin or jaeger.

@tungphuong
Copy link
Author

@tungphuong tungphuong commented Jul 25, 2018

Thanks, I am trying to do like that with delegating handlers. Could you please drop me some sample code? I will try

@tungphuong
Copy link
Author

@tungphuong tungphuong commented Jul 25, 2018

@TomPallister I know you are ready to support Butterfly. But it is still in preview. So, it is difficult to use for production. So, I suggest we should support Jaeger.

@geffzhang
Copy link
Contributor

@geffzhang geffzhang commented Jul 25, 2018

@TomPallister
Copy link
Member

@TomPallister TomPallister commented Jul 25, 2018

OK cool, If anyone wants to pick this work up please feel free to do so!

@TomPallister
Copy link
Member

@TomPallister TomPallister commented Jul 31, 2018

started looking at this, I'm going to start breaking the dependencies like butterfly out into there own Ocelot.xxx packages e.g. the first one will be Ocelot.Butterfly. I will have some kind of interface that all the tracing libraries can sustain. This is my general idea and I will see if it works before pushing new versions etc :)

@TomPallister
Copy link
Member

@TomPallister TomPallister commented Aug 2, 2018

@geffzhang from looking at Skywalking docs I dont think that you would need to do an Ocelot integration? I will see how it works.

@geffzhang
Copy link
Contributor

@geffzhang geffzhang commented Aug 3, 2018

@TomPallister It was NET Core Probe。http://www.cnblogs.com/liuhaoyang/p/skywalking-dotnet-v02-release.html
Now we can remove butterfly.

@tungphuong
Copy link
Author

@tungphuong tungphuong commented Aug 5, 2018

@TomPallister Do you have plan to support Jeager?

@TomPallister
Copy link
Member

@TomPallister TomPallister commented Aug 11, 2018

@tungphuong yes in the future, it isn't something I'm working on at the moment. I need to finish #529 before I do this work because I cannot bring more dependencies into Ocelot. Users must be able to pick their dependencies more specifically.

@tungphuong
Copy link
Author

@tungphuong tungphuong commented Aug 16, 2018

@TomPallister many thanks, I am waiting for this feature.

@TomPallister
Copy link
Member

@TomPallister TomPallister commented Aug 17, 2018

No worries, while you are waiting you might be able to implement for your use case using DelegatingHandlers feature in Ocelot but im not 100% sure.

@kjellegafvelin
Copy link

@kjellegafvelin kjellegafvelin commented Mar 25, 2020

I'm currently looking in to add OpenTracing support to Ocelot. Is there anyone else doing this too?

@tungphuong
Copy link
Author

@tungphuong tungphuong commented Apr 5, 2020

Currently, I am using "OpenTelemetry" in my project. It is quite good; I will update link then

@EngRajabi
Copy link
Contributor

@EngRajabi EngRajabi commented May 12, 2020

support jaeger and zipkin.
These two pamphlets are the best tools

@kjellegafvelin
Copy link

@kjellegafvelin kjellegafvelin commented Jun 1, 2020

With the Open Tracing support I added you can use Jaeger, Zipkin or any other tracing tool as long as it has a .Net client with the Open Tracing interfaces.

@TomPallister maybe it's time to close this one now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.