The Wayback Machine - https://web.archive.org/web/20201125013428/https://github.com/xamarin/Xamarin.Forms/pull/12370
Skip to content

/ Xamarin.Forms

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Button on ListView should not pass click to listview when disabled #12370

Open
wants to merge 1 commit into
base: 5.0.0
from
Open

fix: Button on ListView should not pass click to listview when disabled #12370

wants to merge 1 commit into from

Conversation

@l4nk4b3l
Copy link

@l4nk4b3l l4nk4b3l commented Oct 5, 2020

Issues Resolved

fixes #8763

Platforms Affected

  • iOS

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

PR Checklist

  • [] Targets the correct branch
  • [] Tests are passing (or failures are unrelated)
Andreas Karpinski
fix: Button on ListView should not pass click to listview when disabled
Loading status checks…
d6530d8
@dnfadmin
Copy link

@dnfadmin dnfadmin commented Oct 5, 2020 •
edited

CLA assistant check
All CLA requirements met.
@rmarinho
rmarinho requested changes Oct 14, 2020
View changes
Copy link
Member

@rmarinho rmarinho left a comment

Is it possible to add a UITest and a sample case so we can see what this is supposed to fix.

Thanks
@samhouts samhouts added this to In Progress in vNext+1 (5.0.0) Nov 2, 2020
@samhouts samhouts moved this from In Progress to In Review in vNext+1 (5.0.0) Nov 3, 2020
@PureWeen PureWeen added this to In progress in v5.0.1 via automation Nov 5, 2020
@PureWeen PureWeen removed this from In Review in vNext+1 (5.0.0) Nov 5, 2020
@samhouts samhouts added this to In Progress in vNext+1 (5.0.0) Nov 5, 2020
@samhouts samhouts removed this from In progress in v5.0.1 Nov 5, 2020
@PureWeen PureWeen added this to In progress in v5.0.1 via automation Nov 5, 2020
@PureWeen PureWeen removed this from In Progress in vNext+1 (5.0.0) Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/listview good first issue hacktoberfest 🍻 hacktoberfest-accepted p/iOS 🍎 t/bug 🐛
4 participants
@l4nk4b3l @dnfadmin @rmarinho @samhouts
You can’t perform that action at this time.