jmagman
Follow
Pinned
2,301 contributions in the last year
Less
More
Contribution activity
June 2021
Created 47 commits in 4 repositories
Created a pull request in flutter/plugins that received 11 comments
Build all iOS example apps on current Flutter stable
Run build-examples --ipa on Flutter 2.2.2 (current stable). Allow the Flutter tool and CocoaPods to migrate project files.
This will reduce working…
+65
−163
•
11
comments
Opened 46 other pull requests in 3 repositories
flutter/flutter
34
merged
3
open
- Split project.dart into CMake and Xcode projects
- Address dev/devicelab todos
- Run build_tests shard and check in project migrations
- Check ios-arm64_x86_64-simulator directory when validating codesigning entitlement
- Migrate flutter_cache to null safety
- Migrate iOS app deployment target from 8.0 to 9.0
- Do not list Android or iOS devices when feature disabled
- Remove tests checking Xcode 11 naming conventions
- Avoid iOS app with extension checks that fail on M1 ARM Macs
- macOS unzip then rsync to delete stale artifacts
- Support iOS arm64 simulator
- Check ios-arm64_armv7 directory when validating codesigning entitlements
- Check for either ios-x86_64-simulator or ios-arm64_x86_64-simulator in module test
- Revert "Set up iOS native integration_tests in ui example project"
- Set up iOS native integration_tests in ui example project
- Revert "Roll Engine from ced58ef9c13e to b9616cad9c7d (14 revisions)"
- Audit devicelab log streaming for nullability
- Revert "Roll Engine from ced58ef9c13e to 86dacc0aad71 (9 revisions)"
- Use -miphonesimulator-version-min when building App.framework for simulator
- Revert "Set up iOS native integration_tests in ui example project"
- Remove unnecessary reference to iOS configuration in README
- Add native iOS screenshots to integration_test
- Fix integration_test podspecs warnings
- Set up iOS native integration_tests in ui example project
- Fix iOS native integration_tests example project
- Some pull requests not shown.
flutter/plugins
8
merged
- [url_launcher] Fix test button check for iOS 15
- [integration_test] Update README installation instructions
- [shared_preferences] Add iOS unit tests
- [camera] Do not trigger flat device orientation on iOS
- [path_provider] Add iOS unit tests
- [ios_platform_images] Add iOS unit tests
- [google_sign_in] Add iOS unit and UI tests
- [webview_flutter] Add iOS integration tests
flutter/infra
1
merged
Reviewed 64 pull requests in 5 repositories
flutter/flutter 50 pull requests
- Split project.dart into CMake and Xcode projects
- [flutter_tools] add un-discoverable preview device
- Migrate flutter_cache to null safety
- Check ios-arm64_x86_64-simulator directory when validating codesigning entitlement
- [flutter_tools] well known device ids
- [flutter_tools] use UWP cpp wrapper for UWP build
- Do not list Android or iOS devices when feature disabled
- adds build number of ios device in flutter devices command
- Remove tests checking Xcode 11 naming conventions
- [versions] remove mockito
- macOS unzip then rsync to delete stale artifacts
- [flutter] unify reassemble and fast reassemble
- migrate host_agent to null safety
- Check ios-arm64_armv7 directory when validating codesigning entitlements
- Check for either ios-x86_64-simulator or ios-arm64_x86_64-simulator in module test
- Take screenshot when drive fails
- Fix watchOS build when companion app is configured with xcode variable
- Use -miphonesimulator-version-min when building App.framework for simulator
- Clean up podspec template
- [flutter_tools] remove mockito from resident web runner tests
- [flutter_tools] tweak README
- [versions] update dependencies
- Add native iOS screenshots to integration_test
- Set up iOS native integration_tests in ui example project
- [flutter_tools] fully remove mocks from resident_runner_test.dart
- Some pull request reviews not shown.
flutter/plugins 11 pull requests
- Don't install cocoapods during CI runs
- Build all iOS example apps on current Flutter stable
- [webview_flutter] Suppress iOS 9 deprecation warnings
- [url_launcher] Fix test button check for iOS 15
- Enable macOS XCTest support
- [flutter_plugin_tools] Migrate xctest command to NNBD
- [flutter_plugin_tools] Remove xctest's --skip
- Enable linting of macOS podspecs
- Standardize XCTest locations and harnesses
- [ios_platform_images] Add iOS unit tests
- [webview_flutter] Add iOS integration tests
flutter/cocoon 1 pull request
flutter/website 1 pull request
google/file.dart 1 pull request
Created an issue in flutter/flutter that received 29 comments
Cirrus task failed: Error getting access token for service account, Invalid JWT Signature
Error getting access token for service account: 400 Bad Request POST https://oauth2.googleapis.com/token {"error":"invalid_grant","error_descriptio…
29
comments
Opened 29 other issues in 2 repositories
flutter/flutter
13
open
14
closed
- Remove gradle_non_android_plugin_test test and builder when no longer needed in stable
- Suppress "Double-quoted include in framework header, expected angle-bracketed instead" warnings
- Migrate existing apps with minimum supported iOS version from 8.0 to 9.0
- -[URLLauncherUITests testLaunch] fails on iOS 15 beta 1
- iOS engine artifacts Flutter.xcframework contains old architecture triples directories
- UIImagePickerController is deprecated in iOS 15
- Some devicelab tests are crashing locally, IosDevice.stopLoggingToSink NoSuchMethodError: The method 'kill' was called on null.
- Engine roll caused post-submit framework failures
- Read/write access to Flutter Xcode CIPD packages
- Update iOS and macOS engine builders to Xcode 12.0
- Build ARM during Mac Host Engine build
- Still see iOS and Android devices after turning off iOS and Android development via "flutter config --no-enable-ios" and "--no-enable-android"
- [tool_crash] ProcessException: Process exited abnormally:Command line invocation: xcodebuild -list, OS error code: -11
- Infra Failure: Step('install xcode') (retcode: 1)
- camera plugin test -[CameraOrientationTests testOrientationNotifications] Failed to set device orientation: Not authorized for performing UI testing actions
- Implement "flutter build macos --config-only"
-
expression_evaluation_web_test failed, "Exception: Received app.stop event while waiting for app.started event", causing
Linux web_tool_tests2.29% flaky - Some tests do not automatically rerun to detect flakes
- toggle_buttons_test "VerticalDirection test when direction is vertical" never completed, Dart Error: Dart_GetNativeFieldsOfArgument: expected 2 'num_fields' but was passed in 2
- LUCI tasks are pending and not being scheduled
- Show Run and queue time in cocoon build dashboard as minutes instead of seconds
- Multiple tests timing out "Waiting for observatory port to be available"
- [tool_crash] NoSuchMethodError: The getter 'uri' was called on null.Receiver: nullTried calling: uri
- thread_CastError: Null check operator used on a null value in LocalizationsGenerator describeLocale
- docs_test failed: tool execution failed: git status exit with non-zero exit code: -1284960497
- Some issues not shown.