The Wayback Machine - https://web.archive.org/web/20210411005146/https://github.com/web-platform-tests/wpt/issues/23253
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint for flags (used mostly in CSS) #23253

Open
TalbotG opened this issue Apr 26, 2020 · 6 comments
Open

Lint for flags (used mostly in CSS) #23253

TalbotG opened this issue Apr 26, 2020 · 6 comments

Comments

@TalbotG
Copy link
Contributor

@TalbotG TalbotG commented Apr 26, 2020

@foolip Philip,

I presume you are one of the wpt maintainers.
Is the svg flag valid or deprecated?
<meta content="svg" name="flags">
I have declared the svg flag in 2 tests
and in 2 reference files so far:
#20033
#21450
svg is not in the list of valid flags
http://web-platform-tests.org/writing-tests/css-metadata.html#requirement-flags
nor in the list of deprecated flags . If
svg flag is incorrect or deprecated, then why the lint verification did not report it?

@foolip foolip changed the title Lint and svg flag Lint for flags (used mostly in CSS) Apr 27, 2020
@foolip
Copy link
Member

@foolip foolip commented Apr 27, 2020

@TalbotG I am indeed still active in WPT, but to get the attention of a wider group of people maintaining it, you can mention @web-platform-tests/wpt-core-team.

It looks like the problem is that there are no lints for any flags at all, valid or invalid. I've renamed the issue to reflect this.

Is the "svg" flag useful for you to add to tests? If so I'd say you can simply keep doing so, and perhaps add a description of when it's useful in http://web-platform-tests.org/writing-tests/css-metadata.html#requirement-flags.

foolip added a commit that referenced this issue Apr 27, 2020
Noticed while searching for "svg" flags. There's no lint for this:
#23253
@TalbotG
Copy link
Contributor Author

@TalbotG TalbotG commented Apr 27, 2020

Is the "svg" flag useful for you to add to tests?

I used to add the "svg" flag for tests that were using an svg object. This was the normal procedure before.

"svg | Requires support for vector graphics (SVG)"
https://wiki.csswg.org/test/format#requirement-flags

There are some web-capable softwares that want to be and/or strive to become (now or in the future) W3C-web-standards-compliant (at least regarding CSS) which may not have support for SVG objects. Therefore why the usage of the svg flag arised. Let's say they import, set up and run the entire CSS repository: they do not want to run tests that have svg objects because their software can not handle those. Then such flag would be useful to them.

I would say that flags' items are useful for filtering or screening tests (regarding a specific criteria) for those who import, create and run repositories of tests.

@TalbotG
Copy link
Contributor Author

@TalbotG TalbotG commented Apr 27, 2020

to get the attention of a wider group of people maintaining it, you can mention @web-platform-tests/wpt-core-team

I wrote down this (useful!) information. Thank you Philip

@stephenmcgruer
Copy link
Contributor

@stephenmcgruer stephenmcgruer commented Apr 27, 2020

If this is a flag that the css folks feel is useful, I think that documenting it (the file is docs/writing-tests/css-metadata.md, PRs are welcome ;)) is a good idea.

Additionally, a lint for css/ against deprecated flags seems reasonable too.

I'm not clear what other lints would be both practical and useful. Meta tags are author-defined, and some authors may with to use them with different names or contents and so I'm not sure we should impose there (even for cases like the flag typos @foolip found). Open to ideas though!

@TalbotG
Copy link
Contributor Author

@TalbotG TalbotG commented Apr 27, 2020

If this is a flag that the css folks feel is useful,

I do not know.
I have checked the documentation of some web-aware and CSS-capable user agents like Prince 13 and Antenna House 7 and to my surprise, they appear to support (at least partially) SVG objects.
Some other newer web-aware and CSS-capable user agents (eg gngr ) do not support SVG objects.

a lint for css/ against deprecated flags seems reasonable too.

I am for a lint for css/ checking against deprecated flags and also unknown or invalid flags. Eg #23264
"border-radius" and "box-shadow" are not - and never were - valid flags.

@TalbotG
Copy link
Contributor Author

@TalbotG TalbotG commented Apr 28, 2020

Some other newer web-aware and CSS-capable user agents (eg gngr ) do not support SVG objects.

With more research, even gngr is looking, planning to support svg objects:
Support for SVG images in gngr

foolip added a commit that referenced this issue Apr 28, 2020
Found because "flag" should be "flags", but the flags in question
aren't and never were valid:
#23253 (comment)
foolip added a commit that referenced this issue Apr 30, 2020
)

Found because "flag" should be "flags", but the flags in question
aren't and never were valid:
#23253 (comment)
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue May 15, 2020
…es of <meta name="flag">, a=testonly

Automatic update from web-platform-tests
[css-backgrounds] Remove some invalid uses of <meta name="flag"> (#23291)

Found because "flag" should be "flags", but the flags in question
aren't and never were valid:
web-platform-tests/wpt#23253 (comment)
--

wpt-commits: cfabf82f21568c28a518b14ff027e936ce92b756
wpt-pr: 23291
xeonchen pushed a commit to xeonchen/gecko that referenced this issue May 15, 2020
…es of <meta name="flag">, a=testonly

Automatic update from web-platform-tests
[css-backgrounds] Remove some invalid uses of <meta name="flag"> (#23291)

Found because "flag" should be "flags", but the flags in question
aren't and never were valid:
web-platform-tests/wpt#23253 (comment)
--

wpt-commits: cfabf82f21568c28a518b14ff027e936ce92b756
wpt-pr: 23291
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue May 20, 2020
…es of <meta name="flag">, a=testonly

Automatic update from web-platform-tests
[css-backgrounds] Remove some invalid uses of <meta name="flag"> (#23291)

Found because "flag" should be "flags", but the flags in question
aren't and never were valid:
web-platform-tests/wpt#23253 (comment)
--

wpt-commits: cfabf82f21568c28a518b14ff027e936ce92b756
wpt-pr: 23291
xeonchen pushed a commit to xeonchen/gecko that referenced this issue May 20, 2020
…es of <meta name="flag">, a=testonly

Automatic update from web-platform-tests
[css-backgrounds] Remove some invalid uses of <meta name="flag"> (#23291)

Found because "flag" should be "flags", but the flags in question
aren't and never were valid:
web-platform-tests/wpt#23253 (comment)
--

wpt-commits: cfabf82f21568c28a518b14ff027e936ce92b756
wpt-pr: 23291
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment