The Wayback Machine - https://web.archive.org/web/20200908061759/https://github.com/algorithm-visualizer/algorithm-visualizer/issues/181/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing for custom colors #181

Open
nadr0 opened this issue Jun 16, 2016 · 4 comments
Open

Allowing for custom colors #181

nadr0 opened this issue Jun 16, 2016 · 4 comments

Comments

@nadr0
Copy link
Contributor

@nadr0 nadr0 commented Jun 16, 2016

When using the flood fill example I realized there was a limitation of color. I thought it would be useful to allow the coder to provide different colors to a Tracer for they can have custom select or notify etc.. colors.

Any thoughts on this? I am gonna mess around with the code to see if I can get something working.

Edit - Pull Request : #188

@nadr0
Copy link
Contributor Author

@nadr0 nadr0 commented Jun 19, 2016

Pull request went through, this can be closed whenever.

@64json 64json closed this Jun 20, 2016
@Alireza-Farahani
Copy link

@Alireza-Farahani Alireza-Farahani commented Dec 12, 2019

I can't find this feature. Seems it's been removed from the code.
I think this is a basic feature and a useful one too. For example in Quicksort, selecting pivot in different color could make things easier to understand.

@64json
Copy link
Member

@64json 64json commented Dec 19, 2019

If I remember correctly, I removed this feature while rewriting the entire code base in React because inconsistent custom colors across different visualizations might rather confuse users. However, since I agree that only having two colors restricts a potentially better visualization, I will reopen the issue until we find a solution for the inconsistency issue.

@64json 64json reopened this Dec 19, 2019
@64json
Copy link
Member

@64json 64json commented Dec 19, 2019

Maybe we can have a color legend?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.