The Wayback Machine - https://web.archive.org/web/20211104112855/https://github.com/PrefectHQ/prefect/issues/4540
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marshmallow Deprecation Warning #4540

Open
marvin-robot opened this issue May 17, 2021 · 0 comments
Open

Marshmallow Deprecation Warning #4540

marvin-robot opened this issue May 17, 2021 · 0 comments
Labels
bug good first issue needs:contributor Prefect Slack Community

Comments

Labels
bug good first issue needs:contributor Prefect Slack Community
2 participants
@madkinsz @marvin-robot
@marvin-robot
Copy link
Member

@marvin-robot marvin-robot commented May 17, 2021

Opened from the Prefect Public Slack Community

elliot: Hey folks is anyone else getting a deprecation warning on marshmallow? Something like:

...
/home/rof/.pyenv/versions/3.9.1/lib/python3.9/site-packages/marshmallow/fields.py:198
/home/rof/.pyenv/versions/3.9.1/lib/python3.9/site-packages/marshmallow/fields.py:198: RemovedInMarshmallow4Warning: Passing field metadata as a keyword arg is deprecated. Use the explicit `metadata=...` argument instead.
...

Tried to update to the latest version of prefect and still no joy!

holm.noah: Yes, I suppose some changes in the usage still needs to be performed

kevin701: Hi <@U01A5UMH7HT>! I’ll bring this up to the team.

elliot: Awesome thanks 👍

kevin701: Do you have a simple flow to reproduce this and what is your Prefect version?

kevin701: Can you try with Python 3.8 as well because 3.9 is experimental?

holm.noah: Hey Kevin, I’ve seen this on Python 3.8 when using prefect.utilities.debug.is_serializable from pytest.

kevin701: Perfect thanks for the info.

kevin701: <@ULVA73B9P> open “Marshmallow Deprecation Warning”

Original thread can be found here.
carlos-alberto added a commit to carlos-alberto/prefect that referenced this issue Aug 24, 2021
Fix marshmallow metadata kwarg deprecation warning
6eb6a65 
PrefectHQ#4540

`serialization` was erroneously using the kwarg `key` to
marshmallow.fields.Dict, this should be `keys`. Marshmallow was seeing
this as `additional_metadata`, so showing a deprecation warning.
@carlos-alberto carlos-alberto mentioned this issue Aug 24, 2021
Merged
3 tasks
carlos-alberto added a commit to carlos-alberto/prefect that referenced this issue Aug 24, 2021
Fix marshmallow metadata kwarg deprecation warning
52b675e 
PrefectHQ#4540

`serialization` was erroneously using the kwarg `key` to
marshmallow.fields.Dict, this should be `keys`. Marshmallow was seeing
this as `additional_metadata`, so showing a deprecation warning.
madkinsz pushed a commit that referenced this issue Aug 24, 2021
@carlos-alberto
Fix marshmallow metadata kwarg deprecation warning (#4903)
8807f33 
#4540

`serialization` was erroneously using the kwarg `key` to
marshmallow.fields.Dict, this should be `keys`. Marshmallow was seeing
this as `additional_metadata`, so showing a deprecation warning.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment