Problem:

A common pattern is:

GUARD(s2n_stuffer_skip_write(stuffer, bytes_to_write));
uint8_t* ptr = suffer->blob.data + stuffer->write_cursor - bytes_to_write;

which could be simplified.

Solution:

*ptr could be an *out parameter to s2n_stuffer_skip_write

• Does this change what S2N sends over the wire? No.
• Does this change any public APIs? No.

As I was running composer to install a new library into our repo, it warned me that:

Package yzalis/identicon is abandoned, you should avoid using it. No replacement was suggested.

I'm not familiar on what packagist.org's process is to declare a package abandoned. I see that the last commit in their repo is from 2019 and there are a number of unanswered issues and pull requests.

I

In tests/suites/test_suite_gcm.function as of 8cad2e22fcfe0154f8f9d648cbec81e9fbd0d885 (which is on the way to 3.0, after #4342 but before #4567), the test function gcm_decrypt_and_verify only tests multipart operation if the expected result of decryption is a success. This is incomplete: it should also test multipart operation in the failure case.

We're still getting some coverage of multi

Please add provider support for the "botan encryption" command and implement the needed AES operations with PKCS#11.
I could not find any command line tool that I can use for that. OpenSSL's PKCS#11 engine does not support AES either.