The Wayback Machine - https://web.archive.org/web/20191115215806/https://github.com/reactiveui/ReactiveUI/pull/2185
Skip to content

/ReactiveUI

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Housekeeping: update contribution guide to mention master #2185

Merged
merged 1 commit into from Oct 1, 2019

Conversation

@rgomez90
Copy link
Contributor

rgomez90 commented Oct 1, 2019

What kind of change does this PR introduce?

Docs Update => Update target base branch when submitting a pull request like spoken in (#2164 (comment))

What is the current behavior?
Wrong target base branch

What is the new behavior?

What might this PR break?
Nothing

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:
@rgomez90
Update CONTRIBUTING.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3330698 
Update target base branch when submitting a pull request like spoken in #2164 (#2164 (comment))
@rgomez90 rgomez90 requested a review from reactiveui/learning-team as a code owner Oct 1, 2019
@glennawatson
glennawatson approved these changes Oct 1, 2019
View changes
Copy link
Contributor

glennawatson left a comment

Awesome thanks for doing this.
@glennawatson glennawatson changed the title Update CONTRIBUTING.md Housekeeping: update contribution guide to mention master Oct 1, 2019
@worldbeater
worldbeater approved these changes Oct 1, 2019
View changes
@RLittlesII RLittlesII merged commit aac1e6a into reactiveui:master Oct 1, 2019
2 checks passed
2 checks passed
ReactiveUI-CI Build #10.3.8+b230480438 succeeded
Details
license/cla All CLA requirements met.
@rgomez90 rgomez90 deleted the rgomez90:patch-1 branch Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants
@rgomez90 @glennawatson @worldbeater @RLittlesII
You can’t perform that action at this time.