The Wayback Machine - https://web.archive.org/web/20201029080322/https://github.com/testcontainers/testcontainers-java/issues/2472
Skip to content

/ testcontainers-java

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support container_name in docker-compose file #2472

Open
krichter722 opened this issue Mar 24, 2020 · 4 comments · May be fixed by #2741
Open

Support container_name in docker-compose file #2472

krichter722 opened this issue Mar 24, 2020 · 4 comments · May be fixed by #2741
Labels
area/docker-compose good first issue help wanted resolution/somedaymaybe

Comments

@krichter722
Copy link

@krichter722 krichter722 commented Mar 24, 2020

docker-compose files which contain container_name are not supported and the creation of DockerComposeContainer fails due to IllegalStateException. This has been introduced in #1151 as a quick fix for unintuitive feedback. If I understand correctly, the option of an implementation was however not discarded, but postponed. This issue is now about the implementation.
@bsideup
Copy link
Member

@bsideup bsideup commented Mar 24, 2020

Hi @krichter722,

Would you like to work on implementing it? Also, do you see it as a blocker for you, or just a nice to have feature?
@isank
Copy link

@isank isank commented Mar 26, 2020

Hi @bsideup,

I would like to work on this.
@reggiemcdonald
Copy link

@reggiemcdonald reggiemcdonald commented May 13, 2020

Has this been finished? I would be interested in working on this if it isn't.
@bsideup
Copy link
Member

@bsideup bsideup commented May 13, 2020

@reggiemcdonald it is still up for grabs 👍
@reggiemcdonald reggiemcdonald linked a pull request that will close this issue May 15, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docker-compose good first issue help wanted resolution/somedaymaybe
4 participants
@bsideup @isank @krichter722 @reggiemcdonald
You can’t perform that action at this time.