The Wayback Machine - https://web.archive.org/web/20210730023046/https://github.com/TeamNewPipe/NewPipe/issues/5419
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirmation before deleting all downloads #5419

Open
1 of 2 tasks
kcpatricio opened this issue Jan 15, 2021 · 5 comments
Open
1 of 2 tasks

Confirmation before deleting all downloads #5419

kcpatricio opened this issue Jan 15, 2021 · 5 comments

Comments

@kcpatricio
Copy link
Task lists! Give feedback

@kcpatricio kcpatricio commented Jan 15, 2021

Checklist

My suggestion is to make a pop up confirmation when selecting the "delete downloaded files" option or a trash can so we can recover those deleted files

Having a single touch wipe is way too dangerous for a backup
As my own experience, a single missclick cost all my backup of temporary videos I had for studying

@SpinHit
Copy link

@SpinHit SpinHit commented Feb 14, 2021

Hello we are two students who want to work on this issue, this is the first time we are contributing to a project if you could help us a little bit it would be great.

@kcpatricio
Copy link
Author

@kcpatricio kcpatricio commented Feb 14, 2021

Hello we are two students who want to work on this issue, this is the first time we are contributing to a project if you could help us a little bit it would be great.

Yeah
How could I help you?

@XiangRongLin
Copy link
Member

@XiangRongLin XiangRongLin commented Feb 14, 2021

@kcpatricio Is this even still the case now?
You have to first click on the "trash" icon, then select "Delete downloaded files", which are 2 actions.

After confirming both, you get a snackbar at the bottom with the "undo" option.

@kcpatricio
Copy link
Author

@kcpatricio kcpatricio commented Feb 14, 2021

@kcpatricio Is this even still the case now?
You have to first click on the "trash" icon, then select "Delete downloaded files", which are 2 actions.

After confirming both, you get a snackbar at the bottom with the "undo" option.

Yes
{
1 click (trash icon)
1 click (delete downloaded files)
All files deleted
3-4 seconds notification at the bottom with undo option
}
But no confirmation request before deleting
My suggestion is to prompt a warning about the wipe action, requesting a confirmation before executing it
Or to change from "delete" to "send to bin" where it would hold files till a given expiration date or manual deletion

@SameenAhnaf
Copy link

@SameenAhnaf SameenAhnaf commented May 14, 2021

@kcpatricio I am not sure why this process has to be so complicated. Personally, I think, a 'Trash' tab under "Downloads" could be added.

Let the videos under "Trash" tab completely undeletable. All information could be automatically deleted 30 days after deletion or after redownloading the video in same or any other resolution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment