The Wayback Machine - https://web.archive.org/web/20210202192819/https://github.com/computationalradiationphysics/picongpu/issues/3033
Skip to content

/ picongpu

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Negative mass and density ratios #3033

Open
Anton-Le opened this issue Aug 22, 2019 · 1 comment
Open

Negative mass and density ratios #3033

Anton-Le opened this issue Aug 22, 2019 · 1 comment
Labels
good first issue

Comments

@Anton-Le
Copy link
Contributor

@Anton-Le Anton-Le commented Aug 22, 2019

Observed problem:
Although providing a negative BASE_DENSITY is not possible this can easily be circumvented by defining a negative densityRatio. Same for mass.
Both cases result in a running code that will eat up execution time and not return meaningful results.

Avoidable case of invalid input porvided by user.
@ax3l
Copy link
Member

@ax3l ax3l commented Aug 23, 2019 •
edited

Thanks for the idea.

this can easily be circumvented ...

We usually do not assume malicious intent by the user and validate instead for user errors, not intentionally unphysical input like potential tachyons that are unlikely to be covered by Maxwell's equations. Negative base densities and masses fall into that category.
But if you like to provide a validation for such input and design it in a way that it is runtime neutral to the kernels that execute this, PRs are very welcome :)
@PrometheusPi PrometheusPi mentioned this issue Nov 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue
2 participants
@ax3l @Anton-Le