The Wayback Machine - https://web.archive.org/web/20201208181923/https://github.com/RetireJS/retire.js/pull/132
Skip to content

/ retire.js

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add html report #132

Open
wants to merge 1 commit into
base: master
from
Open

Add html report #132

wants to merge 1 commit into from

Conversation

@danielyefet
Copy link

@danielyefet danielyefet commented May 31, 2016

  • Added HTML report (we're currently using this in our build process, i.e. in a TeamCity tab)
  • Fixed SSL Cert Issue that was only happening when using Request (works with the HTTPS module)
  • Switched to Lodash instead of Underscore (couldn't get Underscore to compare objects for equality)
@danielyefet Daniel Yefet
Add html report
aef3764
@eoftedal
Copy link
Contributor

@eoftedal eoftedal commented Aug 23, 2016

Sorry, but completely forgot about this PR.
Which SSL Cert issues is that? By removing request and going back to https, you appear to have also removed the proxy...
@danielyefet
Copy link
Author

@danielyefet danielyefet commented Aug 24, 2016

No worries!

I didn't mean to remove the proxy - whoops :-/

To be honest, it's pretty hard to tell what the issue is where I am (I think I made the assumption it was an SSL thing); a lot of things are blocked by the security team. I know that using the HTTPS module worked and Request didn't... I'm happy to just put Request back if you like and you can merge the rest of it (if you want it) because I believe the issue can be solved with our security team!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@danielyefet @eoftedal
You can’t perform that action at this time.