Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Fix and make its Debian package modern #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifying empty build-indep: target does not have any meanings.
… 1.0 Write it as more Debian way, use copyright format 1.0 See https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Changes-By: lintian-brush Fixes: lintian: missing-debian-source-format See-also: https://lintian.debian.org/tags/missing-debian-source-format.html Fixes: lintian: older-source-format See-also: https://lintian.debian.org/tags/older-source-format.html
W: github-backup-utils: syntax-error-in-debian-changelog line 144 "found trailer where expected start of change data" W: github-backup-utils: syntax-error-in-debian-changelog line 155 "found trailer where expected start of change data" W: github-backup-utils: syntax-error-in-debian-changelog line 160 "found trailer where expected start of change data" W: github-backup-utils: syntax-error-in-debian-changelog line 45 "badly formatted trailer line" W: github-backup-utils: syntax-error-in-debian-changelog line 47 "found start of entry where expected more change data or trailer"
As debian package, "Runs under most Linux/Unix environments." comment is unnecessary, "MIT licensed, open source software maintained by GitHub, Inc." is also no meaning for users (It should be documented on other file/items on debian/control).
"Architecture:" field shows it depends which architecture, if you specify it as "any" it would be converted on build host arch. "all" means architecture independs. Well, this package does not contain any architecture depend files. No .so files, and /usr/bin/* files are shellscripts. > $ file ghe-* > ghe-backup: Bourne-Again shell script, ASCII text executable > ghe-host-check: Bourne-Again shell script, ASCII text executable > ghe-restore: Bourne-Again shell script, ASCII text executable So it should be "Architecture: all", not "any".
This does not require access to root (or fakeroot), so set it as.
> commit 1de3dd4 > Author: Twan Wolthof <twan@xeago.nl> > Date: Wed Feb 4 16:34:19 2015 +0100 > > Add devscripts to debian's build-depends for checkbashisms However, not necessary to build package itself, so it should be removed.
current oldstable "stretch" has debhelper v10, so we can use 10.
We can improve deb package with current debian-policy 4.5.1, so declare it.
It seems that Twan Wolthof <xeago@spotify.com> does not have any responsibility for maintaining this package now. someone@github.com should be specified as Maintainer in fact. If other than Zachary would update this package too, just add it as "Uploaders: foobar <foobar@github.com>" or so.
1. Add help2man as Build dependency via debian/control 2. Run it on build time via debian/rules 3. Install it via debian/manpages 4. Add clean target via debian/clean
henrich
pushed a commit
to henrich/backup-utils
that referenced
this pull request
May 13, 2021
As github#732 , help2man is needed.
Well, GitHub workflow specifies ubuntu 16.04 as test env. It is now under EMS stage (https://lists.ubuntu.com/archives/ubuntu-announce/2021-March/000266.html) but is still there. We can ignore that as "package build" env, but once revert changes
|
Note: a test failure on macos-latest is fixed with #733 (more strict shellcheck behavior since ubuntu-* env use v0.7.0 but macos env uses latest 0.7.2). |
|
Hmm, macos-latest failed with another issue
Of course, it is not related to this PR and merged shellcheck fix PR :) |
zachary-mark
reviewed
Jun 8, 2021
Apologies for the delay on reviewing this pull request! We were in the process of getting 3.1.0 GAed and this fell a bit by the wayside.
This looks awesome! I've hit the button to merge master into this PR and if everything passes I will give this one last look before approval - I tried it out myself on a stretch system that I use on a regular basis and things seem to be working correctly.
zachary-mark
approved these changes
Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
With the power of lintian, lintian-brush, and my DD experience, fix all lintian warnings for the deb package (bonus: add man pages).
And also fix this package as arch-indep package (arch: amd64 -> arch: all). It means we can install this package on arm64 hosts without a rebuild.