The Wayback Machine - https://web.archive.org/web/20211013212250/https://github.com/dandavison/delta/issues/96
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve binary file added output #96

Open
dandavison opened this issue Feb 12, 2020 · 5 comments
Open

Improve binary file added output #96

dandavison opened this issue Feb 12, 2020 · 5 comments
Labels
good first issue

Comments

@dandavison
Copy link
Owner

@dandavison dandavison commented Feb 12, 2020 •
edited

Ref #94. It might be better for the output to say something like

added: foo (binary file)

than the current

Binary files /dev/null and b/foo differ
@dandavison dandavison mentioned this issue Feb 12, 2020
Merged
@anchnk
Copy link

@anchnk anchnk commented Sep 4, 2020

Has this been implemented yet? Otherwise I am down to work on it as it seems a good fit to get started contributing to the repository
@dandavison
Copy link
Owner Author

@dandavison dandavison commented Sep 4, 2020

Hey @anchnk, great! Go for it. I have not started on it.
@anchnk
Copy link

@anchnk anchnk commented Sep 5, 2020

I had a quick look and I will dive deeper in a few but it seems that the project structure drastically changed. I could replay all the commits since then but I thought it might be faster to ask where is the relevant test located now?
@dandavison
Copy link
Owner Author

@dandavison dandavison commented Sep 5, 2020

Right, the codebase changed a lot around March/April this year. The test named test_binary_files_differ is in src/tests/test_example_diffs.rs now.
@anchnk
Copy link

@anchnk anchnk commented Sep 5, 2020

Thank you very much for your help. I was able to identify the test and where's the condition that identifies binary files modification is (thx to #94 ). Now I am trying to figuring out how to implement the new output. Should we have 3 different outputs for each scenario? Such as:

  • added: foo (binary file)
  • modified: foo (binary file)
  • removed: foo (binary file)

Also, where's the delta output built? I am still grasping the code to see how it works but breaking this task in actionable items would greatly help to grasp the codebase.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue
2 participants
@dandavison @anchnk