The Wayback Machine - https://web.archive.org/web/20210605231354/https://github.com/rjsf-team/react-jsonschema-form/issues/1828
Skip to content

/ react-jsonschema-form

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "git add" commands from lint-staged #1828

Open
epicfaace opened this issue Jun 25, 2020 · 11 comments
Open

Remove "git add" commands from lint-staged #1828

epicfaace opened this issue Jun 25, 2020 · 11 comments
Labels
good first issue

Comments

@epicfaace
Copy link
Member

@epicfaace epicfaace commented Jun 25, 2020

I get this warning when committing:

@rjsf/core: ⚠ Some of your tasks use `git add` command. Please remove it from the config since all modifications made by tasks will be automatically added to the git commit index.
@Aadi-27
Copy link

@Aadi-27 Aadi-27 commented Oct 4, 2020

Okay, I will pick this up
@OlushesiToheeb
Copy link
Contributor

@OlushesiToheeb OlushesiToheeb commented Nov 13, 2020

I'll like to work on this @epicfaace
@galanggg
Copy link
Contributor

@galanggg galanggg commented Mar 8, 2021

Hi @epicfaace , is this issue still available?
@epicfaace
Copy link
Member Author

@epicfaace epicfaace commented Mar 8, 2021

Yes, it is!
@OlushesiToheeb
Copy link
Contributor

@OlushesiToheeb OlushesiToheeb commented Mar 8, 2021

@galanggg are you working on this already? had forgot i commented on this
@galanggg
Copy link
Contributor

@galanggg galanggg commented Mar 8, 2021

I happen to be working on it, do you still want to take this issue? @OlushesiToheeb
@OlushesiToheeb
Copy link
Contributor

@OlushesiToheeb OlushesiToheeb commented Mar 8, 2021

@galanggg Yes I'll love to and @epicfaace I saw the git add in core , material ui and semantic ui package.json lintstage should I just remove it in all, push to a new branch and make a pull request?
@epicfaace
Copy link
Member Author

@epicfaace epicfaace commented Mar 9, 2021

Yes, please do!
@OlushesiToheeb
Copy link
Contributor

@OlushesiToheeb OlushesiToheeb commented Mar 9, 2021

@epicfaace they're some are I'm facing here , the first image was when trying to do npm install just prettier config but I got that error then the second was when i was trying to commit my changes. kindly check out and let me know what I should have done or what I'm doing wrong.
image
image
@epicfaace
Copy link
Member Author

@epicfaace epicfaace commented Mar 9, 2021

Did you run npm install from the root directory first?
@epicfaace
Copy link
Member Author

@epicfaace epicfaace commented Mar 9, 2021 •
edited

Also, I think your first screenshot cuts off the actual error message. Can you send me what you meant there?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue
4 participants
@epicfaace @galanggg @OlushesiToheeb @Aadi-27