Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Trim some HttpHeader parsing logic on browser-wasm #52572
Draft
+14
−11
Conversation
Introduce a new feature switch: System.Net.Http.MinimalHeaderValidation. When set to `true`, this switch will allow for trimming header parsing logic that may not be needed in the app. Contributes to #44534
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsIntroduce a new feature switch: Contributes to #44534 Before: 2,644,974 bytes So roughly 4.5KB .br compressed savings in a Blazor WASM app. Opening this PR as "draft" to get feedback on the approach. I'm not convinced this savings is worth the tradeoff. Can anyone think of more header parsers that could be removed with the proposed feature switch?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Introduce a new feature switch:
System.Net.Http.MinimalHeaderValidation. When set totrue, this switch will allow for trimming header parsing logic that may not be needed in the app.Contributes to #44534
Before: 2,644,974 bytes
After: 2,640,488 bytes (with new feature switch set)
So roughly 4.5KB .br compressed savings in a Blazor WASM app. Opening this PR as "draft" to get feedback on the approach. I'm not convinced this savings is worth the tradeoff. Can anyone think of more header parsers that could be removed with the proposed feature switch?
cc @CoffeeFlux @marek-safar