The Wayback Machine - https://web.archive.org/web/20210506070845/https://github.com/dotnet/runtime/pull/52196
Skip to content

/ runtime

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the SDK to 6.0 Preview 3 #52196

Merged
merged 3 commits into from May 4, 2021
Merged

Update the SDK to 6.0 Preview 3 #52196

merged 3 commits into from May 4, 2021
+7 −8

Conversation

@ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented May 3, 2021

Updating the minimum and target version of the SDK to 6.0 Preview 3.

Contributes to #51716
@ViktorHofer
Update the SDK to 6.0 Preview 3
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
71b0593 
Updating the minimum and target version of the SDK to 6.0 Preview 3.

Contributes to #51716
@ViktorHofer ViktorHofer added this to the 6.0.0 milestone May 3, 2021
@ViktorHofer ViktorHofer requested a review from dotnet/runtime-infrastructure May 3, 2021
@ViktorHofer ViktorHofer self-assigned this May 3, 2021
@msftbot
Copy link
Contributor

@msftbot msftbot bot commented May 3, 2021

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Updating the minimum and target version of the SDK to 6.0 Preview 3.

Contributes to #51716

Author: ViktorHofer
Assignees: ViktorHofer
Labels:

area-Infrastructure
Milestone: 6.0.0
@msftbot msftbot bot added this to In Progress in Infrastructure Backlog May 3, 2021
@ViktorHofer ViktorHofer mentioned this pull request May 3, 2021
Closed
@safern
safern approved these changes May 3, 2021
View changes
@eerhardt
Copy link
Member

@eerhardt eerhardt commented May 3, 2021

@joperezr - can you look into unblocking the dotnet-linker-tests?
@ericstj
ericstj approved these changes May 3, 2021
View changes
@joperezr
Copy link
Member

@joperezr joperezr commented May 3, 2021

Sure taking a look
@hoyosjs hoyosjs mentioned this pull request May 3, 2021
Open
@Anipik
Anipik approved these changes May 3, 2021
View changes
@joperezr
Fix Linker Trimming tests
Loading status checks…
4730d28
@joperezr
Copy link
Member

@joperezr joperezr commented May 3, 2021

linker tests are passing locally after that change I just pushed, so hopefully that will be enough for merging.

TL;DR for those interested, the new SDK has now a)Enabled a linker roslyn analyzer by default which was throwing some errors and b) it changed some defaults of when linker warnings are suppressed. My latest commit will just disable the analyzer for our tests and re-add the trimming warning suppressions we had before the sdk bump.
@eerhardt
eerhardt approved these changes May 4, 2021
View changes
Copy link
Member

@eerhardt eerhardt left a comment

The trimming tests changes look fine to me.
@ViktorHofer
Copy link
Member Author

@ViktorHofer ViktorHofer commented May 4, 2021 •
edited

@joperezr @eerhardt can you please also look at the remaining linker warnings from the other failing legs?
@eerhardt
Copy link
Member

@eerhardt eerhardt commented May 4, 2021 

 error IL2009: (NETCORE_ENGINEERING_TELEMETRY=Build) Could not find method 'ApplyUpdateSdb' on type 'System.Reflection.Metadata.AssemblyExtensions'

Looks like we have a dangling reference to a method that was removed in #51954. I'll remove the entry in the ILLink.Descriptors.xml file.

fyi @lambdageek
@eerhardt
Fix ILLink warnings for latest SDK
Loading status checks…
fdbe52a 
- Remove ILLink.Descriptors entry for non-existant method
- Suppress ILLink warnings in mobile tests
@ViktorHofer ViktorHofer requested a review from marek-safar as a code owner May 4, 2021
@marek-safar
marek-safar approved these changes May 4, 2021
View changes
@ViktorHofer
Copy link
Member Author

@ViktorHofer ViktorHofer commented May 4, 2021

Failure is #11063
The timeout is due to the product build taking 105 minutes which is unacceptable. Likely because of a slow machine again.
@ViktorHofer ViktorHofer merged commit 4c7ae35 into main May 4, 2021
97 of 100 checks passed
97 of 100 checks passed
@azure-pipelines
runtime Build #20210504.34 had test failures
Details
@azure-pipelines
runtime (Mono Pri0 Runtime Tests Run OSX x64 release) Mono Pri0 Runtime Tests Run OSX x64 release failed
Details
@azure-pipelines
runtime (Mono crossaot Product Build OSX x64 release) Mono crossaot Product Build OSX x64 release was canceled
Details
@net-helix
Build Analysis Build Result Analysis
Details
@azure-pipelines
dotnet-linker-tests Build #20210504.36 succeeded
Details
@azure-pipelines
dotnet-linker-tests (Build Browser wasm release Runtime_Release) Build Browser wasm release Runtime_Release succeeded
Details
@azure-pipelines
dotnet-linker-tests (Build Linux x64 release Runtime_Release) Build Linux x64 release Runtime_Release succeeded
Details
@azure-pipelines
dotnet-linker-tests (Build OSX x64 release Runtime_Release) Build OSX x64 release Runtime_Release succeeded
Details
@azure-pipelines
dotnet-linker-tests (Build windows x64 release Runtime_Release) Build windows x64 release Runtime_Release succeeded
Details
license/cla All CLA requirements met.
Details
@azure-pipelines
runtime (Build Browser wasm Release AllSubsets_Mono) Build Browser wasm Release AllSubsets_Mono succeeded
Details
@azure-pipelines
runtime (Build Browser wasm Release AllSubsets_Mono_RuntimeTests) Build Browser wasm Release AllSubsets_Mono_RuntimeTests succeeded
Details
@azure-pipelines
runtime (Build Linux arm Debug AllSubsets_Mono) Build Linux arm Debug AllSubsets_Mono succeeded
Details
@azure-pipelines
runtime (Build Linux arm64 Debug AllSubsets_Mono_LLVMJIT) Build Linux arm64 Debug AllSubsets_Mono_LLVMJIT succeeded
Details
@azure-pipelines
runtime (Build Linux arm64 Release AllSubsets_Mono_LLVMAOT) Build Linux arm64 Release AllSubsets_Mono_LLVMAOT succeeded
Details
@azure-pipelines
runtime (Build Linux x64 Debug AllSubsets_Mono_LLVMJIT) Build Linux x64 Debug AllSubsets_Mono_LLVMJIT succeeded
Details
@azure-pipelines
runtime (Build Linux x64 Release AllSubsets_Mono_LLVMAOT) Build Linux x64 Release AllSubsets_Mono_LLVMAOT succeeded
Details
@azure-pipelines
runtime (Build Linux x64 Release SingleFile) Build Linux x64 Release SingleFile succeeded
Details
@azure-pipelines
runtime (Build Linux_musl x64 Release AllSubsets_Mono) Build Linux_musl x64 Release AllSubsets_Mono succeeded
Details
@azure-pipelines
runtime (Build MacCatalyst arm64 Debug AllSubsets_Mono) Build MacCatalyst arm64 Debug AllSubsets_Mono succeeded
Details
@azure-pipelines
runtime (Build MacCatalyst x64 Debug AllSubsets_Mono) Build MacCatalyst x64 Debug AllSubsets_Mono succeeded
Details
@azure-pipelines
runtime (Build OSX x64 Debug AllSubsets_Mono_LLVMAOT) Build OSX x64 Debug AllSubsets_Mono_LLVMAOT succeeded
Details
@azure-pipelines
runtime (Build OSX x64 Release AllSubsets_Mono_LLVMJIT) Build OSX x64 Release AllSubsets_Mono_LLVMJIT succeeded
Details
@azure-pipelines
runtime (Build iOS arm Release AllSubsets_Mono) Build iOS arm Release AllSubsets_Mono succeeded
Details
@azure-pipelines
runtime (Build iOS arm64 Debug AllSubsets_Mono) Build iOS arm64 Debug AllSubsets_Mono succeeded
Details
@azure-pipelines
runtime (Build iOSSimulator x86 Debug AllSubsets_Mono) Build iOSSimulator x86 Debug AllSubsets_Mono succeeded
Details
@azure-pipelines
runtime (Build tvOS arm64 Release AllSubsets_Mono) Build tvOS arm64 Release AllSubsets_Mono succeeded
Details
@azure-pipelines
runtime (Build tvOSSimulator x64 Debug AllSubsets_Mono) Build tvOSSimulator x64 Debug AllSubsets_Mono succeeded
Details
@azure-pipelines
runtime (Build windows x64 Release SingleFile) Build windows x64 Release SingleFile succeeded
Details
@azure-pipelines
runtime (CoreCLR Pri0 Runtime Tests Run Linux arm checked) CoreCLR Pri0 Runtime Tests Run Linux arm checked succeeded
Details
@azure-pipelines
runtime (CoreCLR Pri0 Runtime Tests Run Linux arm64 checked) CoreCLR Pri0 Runtime Tests Run Linux arm64 checked succeeded
Details
@azure-pipelines
runtime (CoreCLR Pri0 Runtime Tests Run Linux x64 checked) CoreCLR Pri0 Runtime Tests Run Linux x64 checked succeeded
Details
@azure-pipelines
runtime (CoreCLR Pri0 Runtime Tests Run OSX x64 checked) CoreCLR Pri0 Runtime Tests Run OSX x64 checked succeeded
Details
@azure-pipelines
runtime (CoreCLR Pri0 Runtime Tests Run windows arm64 checked) CoreCLR Pri0 Runtime Tests Run windows arm64 checked succeeded
Details
@azure-pipelines
runtime (CoreCLR Pri0 Runtime Tests Run windows x64 checked) CoreCLR Pri0 Runtime Tests Run windows x64 checked succeeded
Details
@azure-pipelines
runtime (CoreCLR Pri0 Runtime Tests Run windows x86 checked) CoreCLR Pri0 Runtime Tests Run windows x86 checked succeeded
Details
@azure-pipelines
runtime (CoreCLR Product Build FreeBSD x64 release) CoreCLR Product Build FreeBSD x64 release succeeded
Details
@azure-pipelines
runtime (CoreCLR Product Build Linux arm checked) CoreCLR Product Build Linux arm checked succeeded
Details
@azure-pipelines
runtime (CoreCLR Product Build Linux arm release) CoreCLR Product Build Linux arm release succeeded
Details
@azure-pipelines
runtime (CoreCLR Product Build Linux arm64 checked) CoreCLR Product Build Linux arm64 checked succeeded
Details
@azure-pipelines
runtime (CoreCLR Product Build Linux arm64 release) CoreCLR Product Build Linux arm64 release succeeded
Details
@azure-pipelines
runtime (CoreCLR Product Build Linux x64 checked) CoreCLR Product Build Linux x64 checked succeeded
Details
@azure-pipelines
runtime (CoreCLR Product Build Linux x64 release PGO) CoreCLR Product Build Linux x64 release PGO succeeded
Details
@azure-pipelines
runtime (CoreCLR Product Build Linux x64 release) CoreCLR Product Build Linux x64 release succeeded
Details
@azure-pipelines
runtime (CoreCLR Product Build Linux_musl arm checked) CoreCLR Product Build Linux_musl arm checked succeeded
Details
@azure-pipelines
runtime (CoreCLR Product Build Linux_musl arm release) CoreCLR Product Build Linux_musl arm release succeeded
Details
@azure-pipelines
runtime (CoreCLR Product Build Linux_musl arm64 checked) CoreCLR Product Build Linux_musl arm64 checked succeeded
Details
@azure-pipelines
runtime (CoreCLR Product Build Linux_musl arm64 release) CoreCLR Product Build Linux_musl arm64 release succeeded
Details
@azure-pipelines
runtime (CoreCLR Product Build Linux_musl x64 checked) CoreCLR Product Build Linux_musl x64 checked succeeded
Details
@azure-pipelines
runtime (CoreCLR Product Build Linux_musl x64 release) CoreCLR Product Build Linux_musl x64 release succeeded
Details
@azure-pipelines
runtime (CoreCLR Product Build OSX arm64 checked) CoreCLR Product Build OSX arm64 checked succeeded
Details
@azure-pipelines
runtime (CoreCLR Product Build OSX arm64 release) CoreCLR Product Build OSX arm64 release succeeded
Details
@azure-pipelines
runtime (CoreCLR Product Build OSX x64 checked) CoreCLR Product Build OSX x64 checked succeeded
Details
@azure-pipelines
runtime (CoreCLR Product Build OSX x64 release) CoreCLR Product Build OSX x64 release succeeded
Details
@azure-pipelines
runtime (CoreCLR Product Build windows arm checked) CoreCLR Product Build windows arm checked succeeded
Details
@azure-pipelines
runtime (CoreCLR Product Build windows arm release) CoreCLR Product Build windows arm release succeeded
Details
@azure-pipelines
runtime (CoreCLR Product Build windows arm64 checked) CoreCLR Product Build windows arm64 checked succeeded
Details
@azure-pipelines
runtime (CoreCLR Product Build windows arm64 release) CoreCLR Product Build windows arm64 release succeeded
Details
@azure-pipelines
runtime (CoreCLR Product Build windows x64 checked) CoreCLR Product Build windows x64 checked succeeded
Details
@azure-pipelines
runtime (CoreCLR Product Build windows x64 release PGO) CoreCLR Product Build windows x64 release PGO succeeded
Details
@azure-pipelines
runtime (CoreCLR Product Build windows x64 release) CoreCLR Product Build windows x64 release succeeded
Details
@azure-pipelines
runtime (CoreCLR Product Build windows x86 checked) CoreCLR Product Build windows x86 checked succeeded
Details
@azure-pipelines
runtime (CoreCLR Product Build windows x86 release PGO) CoreCLR Product Build windows x86 release PGO succeeded
Details
@azure-pipelines
runtime (CoreCLR Product Build windows x86 release) CoreCLR Product Build windows x86 release succeeded
Details
@azure-pipelines
runtime (CoreCLR Tools Unit Tests Linux x64 checked) CoreCLR Tools Unit Tests Linux x64 checked succeeded
Details
@azure-pipelines
runtime (CoreCLR Common Pri0 Test Build AnyOS AnyCPU checked) CoreCLR Common Pri0 Test Build AnyOS AnyCPU checked succeeded
Details
@azure-pipelines
runtime (CoreCLR GCC Product Build Linux x64 checked) CoreCLR GCC Product Build Linux x64 checked succeeded
Details
@azure-pipelines
runtime (Evaluate Paths) Evaluate Paths succeeded
Details
@azure-pipelines
runtime (Formatting Linux x64) Formatting Linux x64 succeeded
Details
@azure-pipelines
runtime (Formatting windows x64) Formatting windows x64 succeeded
Details
@azure-pipelines
runtime (Installer Build and Test coreclr FreeBSD_x64 Release) Installer Build and Test coreclr FreeBSD_x64 Release succeeded
Details
@azure-pipelines
runtime (Installer Build and Test coreclr Linux_arm Debug) Installer Build and Test coreclr Linux_arm Debug succeeded
Details
@azure-pipelines
runtime (Installer Build and Test coreclr Linux_arm64 Release) Installer Build and Test coreclr Linux_arm64 Release succeeded
Details
@azure-pipelines
runtime (Installer Build and Test coreclr Linux_musl_arm Debug) Installer Build and Test coreclr Linux_musl_arm Debug succeeded
Details
@azure-pipelines
runtime (Installer Build and Test coreclr Linux_musl_arm64 Debug) Installer Build and Test coreclr Linux_musl_arm64 Debug succeeded
Details
@azure-pipelines
runtime (Installer Build and Test coreclr Linux_musl_x64 Release) Installer Build and Test coreclr Linux_musl_x64 Release succeeded
Details
@azure-pipelines
runtime (Installer Build and Test coreclr Linux_x64 Release) Installer Build and Test coreclr Linux_x64 Release succeeded
Details
@azure-pipelines
runtime (Installer Build and Test coreclr OSX_arm64 Release) Installer Build and Test coreclr OSX_arm64 Release succeeded
Details
@azure-pipelines
runtime (Installer Build and Test coreclr OSX_x64 Release) Installer Build and Test coreclr OSX_x64 Release succeeded
Details
@azure-pipelines
runtime (Installer Build and Test coreclr windows_arm Debug) Installer Build and Test coreclr windows_arm Debug succeeded
Details
@azure-pipelines
runtime (Installer Build and Test coreclr windows_arm64 Debug) Installer Build and Test coreclr windows_arm64 Debug succeeded
Details
@azure-pipelines
runtime (Installer Build and Test coreclr windows_x64 Release) Installer Build and Test coreclr windows_x64 Release succeeded
Details
@azure-pipelines
runtime (Installer Build and Test coreclr windows_x86 Debug) Installer Build and Test coreclr windows_x86 Debug succeeded
Details
@azure-pipelines
runtime (Libraries Build FreeBSD x64 Debug) Libraries Build FreeBSD x64 Debug succeeded
Details
@azure-pipelines
runtime (Libraries Build Linux arm Release) Libraries Build Linux arm Release succeeded
Details
@azure-pipelines
runtime (Libraries Build Linux arm64 Debug) Libraries Build Linux arm64 Debug succeeded
Details
@azure-pipelines
runtime (Libraries Build Linux x64 Debug) Libraries Build Linux x64 Debug succeeded
Details
@azure-pipelines
runtime (Libraries Build Linux_musl arm Release) Libraries Build Linux_musl arm Release succeeded
Details
@azure-pipelines
runtime (Libraries Build Linux_musl arm64 Release) Libraries Build Linux_musl arm64 Release succeeded
Details
@azure-pipelines
runtime (Libraries Build Linux_musl x64 Debug) Libraries Build Linux_musl x64 Debug succeeded
Details
@azure-pipelines
runtime (Libraries Build OSX arm64 Debug) Libraries Build OSX arm64 Debug succeeded
Details
@azure-pipelines
runtime (Libraries Build OSX x64 Debug) Libraries Build OSX x64 Debug succeeded
Details
@azure-pipelines
runtime (Libraries Build windows allConfigurations x64 Debug) Libraries Build windows allConfigurations x64 Debug succeeded
Details
@azure-pipelines
runtime (Libraries Build windows arm Release) Libraries Build windows arm Release succeeded
Details
@azure-pipelines
runtime (Libraries Build windows arm64 Release) Libraries Build windows arm64 Release succeeded
Details
@azure-pipelines
runtime (Libraries Build windows net48 x86 Release) Libraries Build windows net48 x86 Release succeeded
Details
@azure-pipelines
runtime (Libraries Build windows x64 Debug) Libraries Build windows x64 Debug succeeded
Details
@azure-pipelines
runtime (Libraries Build windows x86 Debug) Libraries Build windows x86 Debug succeeded
Details
@azure-pipelines
runtime (Libraries Build windows x86 Release) Libraries Build windows x86 Release succeeded
Details
@azure-pipelines
runtime (Libraries Test Run checked coreclr Linux arm Release) Libraries Test Run checked coreclr Linux arm Release succeeded
Details
Infrastructure Backlog automation moved this from In Progress to Done May 4, 2021
@ViktorHofer ViktorHofer deleted the ViktorHofer-sdkupgrade-p3 branch May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Infrastructure
7 participants
@ViktorHofer @eerhardt @joperezr @marek-safar @ericstj @Anipik @safern