The Wayback Machine - https://web.archive.org/web/20201124063706/https://github.com/knaxus/problem-solving-javascript/issues/143
Skip to content

/ problem-solving-javascript

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Unit Test For - get-unique-words for Trie #143

Open
TheSTL opened this issue Oct 25, 2019 · 4 comments
Open

Add Unit Test For - get-unique-words for Trie #143

TheSTL opened this issue Oct 25, 2019 · 4 comments
Labels
claimed-already good first issue

Comments

@TheSTL
Copy link
Member

@TheSTL TheSTL commented Oct 25, 2019

馃懡 What is required?

The algorithm is here : get-unique-words

  • Follow the ESLint rules strictly
  • Follow the filename and folder structure strictly
  • Since the Contribution Guide is not ready yet, go through the codebase pattern and add tests accordingly

Thank You!
@ChristieRobson ChristieRobson mentioned this issue Oct 26, 2019
Merged
@garrowp
Copy link

@garrowp garrowp commented Oct 27, 2019

I can pick up this one
@garrowp garrowp mentioned this issue Oct 27, 2019
Open
@ashokdey
Copy link
Member

@ashokdey ashokdey commented Oct 27, 2019

Thanks for taking interest @garrowp, however, we already have #148 and #149. Can you continue with the changes asked in those two PRs?
@garrowp
Copy link

@garrowp garrowp commented Oct 28, 2019 •
edited

Sure! Do you want me to make new PRs or just reference those existing PRs?
@ashokdey
Copy link
Member

@ashokdey ashokdey commented Oct 28, 2019

You can pick up those
@ashokdey ashokdey removed the Hacktoberfest label Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
claimed-already good first issue
3 participants
@ashokdey @garrowp @TheSTL
You can鈥檛 perform that action at this time.