The Wayback Machine - https://web.archive.org/web/20210515083857/https://github.com/TheAlgorithms/Python/pull/4334
Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rgb_hsv_conversion.py #4334

Merged
merged 3 commits into from Apr 23, 2021
Merged

Add rgb_hsv_conversion.py #4334

merged 3 commits into from Apr 23, 2021

Conversation

@algobytewise
Copy link
Contributor

@algobytewise algobytewise commented Apr 15, 2021

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
algobytewise and others added 2 commits Apr 15, 2021
@algobytewise
Add rgb_hsv_conversion.py
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
217b7a5
github-actions github-actions
updating DIRECTORY.md
Loading status checks…
f2716e6
@algorithms-keeper
algorithms-keeper bot reviewed Apr 15, 2021
View changes
Copy link

@algorithms-keeper algorithms-keeper bot left a comment

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
conversions/rgb_hsv_conversion.py Outdated
raise Exception("value should be between 0 and 1")

chroma = value * saturation
hueSection = hue / 60

This comment has been minimized.

Sign in to view
@algorithms-keeper

algorithms-keeper bot Apr 15, 2021

Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: hueSection
@algobytewise
snake-case
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
b5ce71a
@mateuszz0000
mateuszz0000 approved these changes Apr 23, 2021
View changes
@mateuszz0000 mateuszz0000 merged commit 1a39970 into TheAlgorithms:master Apr 23, 2021
2 checks passed
2 checks passed
@github-actions
build
Details
@github-actions
pre-commit
Details
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@algobytewise github-actions
Add rgb_hsv_conversion.py (TheAlgorithms#4334)
9d37ec0 
* Add rgb_hsv_conversion.py

* updating DIRECTORY.md

* snake-case

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@algobytewise @mateuszz0000