The Wayback Machine - https://web.archive.org/web/20210421082146/https://github.com/RocketChat/Rocket.Chat/pull/20478
Skip to content

/ Rocket.Chat

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc: Corrected links to documentation of rocket.chat README.md #20478

Merged
merged 17 commits into from Apr 5, 2021
Merged

Doc: Corrected links to documentation of rocket.chat README.md #20478

merged 17 commits into from Apr 5, 2021

Conversation

@joshi008
Copy link
Contributor

@joshi008 joshi008 commented Jan 28, 2021 •
edited

Fix Documentation:

Proposed changes

The link for documentation in the readme was previously https://rocket.chat/docs/ while that was not working and according to the website it was https://docs.rocket.chat/
The link for deployment methods in readme was corrected from https://rocket.chat/docs/installation/paas-deployments/ to https://docs.rocket.chat/installation/paas-deployments
Some more links to the documentations were giving 404 error which hence updated.

Issue(s)

The link was not correct for documentation in the readme.

Steps to test or reproduce

This requires no test

Further comments

Closes #20525
@joshi008
Corrected the link to documentation of rocket.chat
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
85c07f8 
The link was previously https://rocket.chat/docs/ while that was not working and according to the website it was https://docs.rocket.chat/
@CLAassistant
Copy link

@CLAassistant CLAassistant commented Jan 28, 2021 •
edited

CLA assistant check
All committers have signed the CLA.
@joshi008 joshi008 changed the title Corrected the link to documentation of rocket.chat [IMPROVE] Corrected the link to documentation of rocket.chat Jan 28, 2021
joshi008 added 2 commits Jan 29, 2021
@joshi008
Update README.md
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
421e264 
Paas Deployment Documentation link corrected
@joshi008
Update README.md
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ec46f77 
Documentation links correction
@joshi008 joshi008 changed the title [IMPROVE] Corrected the link to documentation of rocket.chat [IMPROVE] Corrected the link to documentation of rocket.chat README.md Jan 29, 2021
@joshi008 joshi008 changed the title [IMPROVE] Corrected the link to documentation of rocket.chat README.md Doc: Corrected the link to documentation of rocket.chat README.md Jan 29, 2021
@joshi008
Merge branch 'develop' into patch-1
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f2493a3
@joshi008
Copy link
Contributor Author

@joshi008 joshi008 commented Jan 29, 2021 •
edited

Could anyone please review it and tell if the links are correct or not.
Not tagging anyone because you might be busy in some serious issue.
Just a help to make readme better :)
joshi008 added 4 commits Jan 30, 2021
@joshi008
Merge branch 'develop' into patch-1
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2afb828
@joshi008
Merge branch 'develop' into patch-1
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7dccbf8
@joshi008
Update README.md
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5d54243
@joshi008
Update README.md
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
921d33f
@joshi008 joshi008 changed the title Doc: Corrected the link to documentation of rocket.chat README.md Doc: Corrected the link to documentation of rocket.chat README.md #20525 Jan 31, 2021
@joshi008 joshi008 changed the title Doc: Corrected the link to documentation of rocket.chat README.md #20525 Doc: Corrected the link to documentation of rocket.chat README.md Jan 31, 2021
@joshi008
Update README.md
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9363837
@joshi008 joshi008 changed the title Doc: Corrected the link to documentation of rocket.chat README.md Doc: Corrected links to documentation of rocket.chat README.md Jan 31, 2021
@joshi008
Merge branch 'develop' into patch-1
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b69b502
@KevLehman
KevLehman approved these changes Feb 4, 2021
View changes
Copy link
Contributor

@KevLehman KevLehman left a comment

LGTM, thanks!
@KevLehman
Copy link
Contributor

@KevLehman KevLehman commented Feb 4, 2021

Can you please update your base branch with the tip of develop? Thanks!
@joshi008
Merge branch 'develop' into patch-1
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
457f136
@joshi008
Copy link
Contributor Author

@joshi008 joshi008 commented Feb 4, 2021

Can you please update your base branch with the tip of develop? Thanks!

Thanks for reviewing @KevLehman . I have updated the branch with develop branch.
joshi008 added 6 commits Feb 5, 2021
@joshi008
Merge branch 'develop' into patch-1
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9f21116
@joshi008
Merge branch 'develop' into patch-1
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f6e22c0
@joshi008
Merge branch 'develop' into patch-1
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e326838
@joshi008
Merge branch 'develop' into patch-1
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9d479cc
@joshi008
Merge branch 'develop' into patch-1
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
14a3b65
@joshi008
Merge branch 'develop' into patch-1
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b7a9042
@aditya-mitra aditya-mitra mentioned this pull request Feb 13, 2021
Merged
@sampaiodiego sampaiodiego merged commit 9b5b915 into RocketChat:develop Apr 5, 2021
13 checks passed
13 checks passed
build
Details
CodeQL-Build CodeQL-Build
Details
build-image-pr
Details
test (12.18.4, 3.4)
Details
test (12.18.4, 3.6)
Details
test (12.18.4, 4.0)
Details
deploy
Details
image-build
Details
services-image-build
Details
LGTM analysis: JavaScript No code changes detected
Details
CodeQL No new or fixed alerts
Details
license/cla Contributor License Agreement is signed.
Details
security/snyk (rodrigok) No manifest changes detected in 5 projects
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants
@joshi008 @CLAassistant @KevLehman @sampaiodiego