Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Implement skips for stringify array format comma #304
Conversation
Closed
| @@ -132,7 +132,7 @@ test('array stringify representation with array commas and null value', t => { | |||
| bar: [null] | |||
| }, { | |||
| arrayFormat: 'comma' | |||
| }), 'foo=a'); | |||
| }), 'bar=&foo=,a,,'); | |||
sindresorhus
Jan 17, 2021
Owner
Can you add a test like this where the skipnull and skipemptystring options are set?
Can you add a test like this where the skipnull and skipemptystring options are set?
sindresorhus
Jan 17, 2021
Owner
You also need to add some more tests to ensure the parse function can correctly handle this.
You also need to add some more tests to ensure the parse function can correctly handle this.
decimoseptimo
Jan 22, 2021
Author
Suggested change
}), 'bar=&foo=,a,,');
fg
}), 'bar=&foo=,a,,');
fdfgfdg
Can you add a test like this where the skipnull and skipemptystring options are set?
one test where both are involved, sure.
You also need to add some more tests to ensure the parse function can correctly handle this.
This fixes stringify(), are you trying to say me to fix its counter-part in parse()?
Suggested change
| }), 'bar=&foo=,a,,'); | |
| fg | |
| }), 'bar=&foo=,a,,'); | |
| fdfgfdg |
Can you add a test like this where the skipnull and skipemptystring options are set?
one test where both are involved, sure.
You also need to add some more tests to ensure the parse function can correctly handle this.
This fixes stringify(), are you trying to say me to fix its counter-part in parse()?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixes #302