Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Get C# to 75% of the C++ perf on my box #6
+68
−38
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
On my own box, C++ measures:
Passes: 16268, Time: 10.000000, Avg: 0.000615, Limit: 1000000, Count: 78498, Valid: 1This builds on @EgorBo's PR in #4 and gets the C# version to
Passes: 12605, Time: 10.0003958, Avg: 0.0007933673780245934, Limit: 1000000, Count: 78498, Valid: Truewhich is ~75% of the perf of the C++ variant.The key points are to elide bounds checks and more closely mirror what C++ in terms of types and code used to make it a more fair comparison. C# inherently does things C++ doesn't, like bounds checks.😄
If the version to version comparisons were to be equally safe (with C++ using things like
std::arrayand doing bounds checking before accesses, eliding where it is statically determined to be "safe"), then C++ wouldn't have such a "clear lead"