The Wayback Machine - https://web.archive.org/web/20210604070823/https://github.com/microsoft/calculator/pull/852
Skip to content

/ calculator

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GraphingCalculator Projects to allow official builds #852

Merged
merged 5 commits into from Dec 11, 2019
Merged

Update GraphingCalculator Projects to allow official builds #852

merged 5 commits into from Dec 11, 2019

Conversation

@sanderl
Copy link
Member

@sanderl sanderl commented Dec 6, 2019

Fixes part of #338 .

Description of the changes:

  • Updated the MockGraphingImpl project to be called GraphingImpl
  • Updated the nuget.config to include the WindowsApps Microsoft feed

How changes were validated:

  • Tested manually
@sanderl
renamed MockGraphingImpl to GraphingImpl, updated the nuget.config to…
4f276ff 
… include the WindowsApps feed
@sanderl sanderl assigned sanderl and mcooley and unassigned sanderl Dec 6, 2019
@mcooley
mcooley requested changes Dec 6, 2019
View changes
Copy link
Member

@mcooley mcooley left a comment

Don’t add non-public NuGet feeds to the public NuGet.config.

Other parts look good.
@sanderl
Revert nuget.config change
66fffcc
@sanderl sanderl changed the title Update GraphingCalculator Mock and Nuget to allow official builds Update GraphingCalculator Projects to allow official builds Dec 10, 2019
@sanderl
Updated vcxproj files to output to the same directory regardless of c…
edfa6e9 
…onfiguration
@mcooley
mcooley reviewed Dec 10, 2019
View changes
src/CalcManager/CalcManager.vcxproj Outdated Show resolved Hide resolved
@sanderl
Removed outder used GenerateProjectSpecificOutputfolder instead
c8e6250
@mcooley
mcooley reviewed Dec 10, 2019
View changes
src/Calculator/Calculator.vcxproj Outdated Show resolved Hide resolved
@sanderl
revert commenting out the temporary.pfx cert in the calculator.vcxpro…
26b6beb 
…j file
@mcooley
mcooley approved these changes Dec 10, 2019
View changes
@sanderl sanderl merged commit f593c62 into microsoft:feature/GraphingCalculator Dec 11, 2019
6 checks passed
6 checks passed
@azure-pipelines
Calculator-CI #0.1912.1018.0 succeeded
Details
@azure-pipelines
Calculator-CI (Build x64) Build x64 succeeded
Details
@azure-pipelines
Calculator-CI (Package) Package succeeded
Details
@azure-pipelines
Calculator-CI (UITests x64) UITests x64 succeeded
Details
@azure-pipelines
Calculator-CI (UnitTests x64) UnitTests x64 succeeded
Details
license/cla All CLA requirements met.
Details
@sanderl sanderl deleted the sanderl:build-updates branch Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
graphing calculator
2 participants
@sanderl @mcooley