GEODE-8886: upgradeTest sometimes fails with new test #6091
Conversation
| import org.apache.geode.test.dunit.VM; | ||
| import org.apache.geode.test.version.VersionManager; | ||
|
|
||
| public class WANRollingUpgradeVerifyGatewaySenderProfile extends WANRollingUpgradeDUnitTest { | ||
| @Test | ||
|
|
||
| // This test verifies that a GatewaySenderProfile serializes properly between versions. | ||
| // Thigit s test verifies that a GatewaySenderProfile serializes properly between versions. |
gesterzhou
Mar 4, 2021
Contributor
typo?
typo?
mhansonp
Mar 5, 2021
Author
Contributor
Yup, but I am not inclined to fix it now. I will fix it when I check the test back in...
Yup, but I am not inclined to fix it now. I will fix it when I check the test back in...
mhansonp
Mar 5, 2021
Author
Contributor
Hopefully that is ok.
Hopefully that is ok.
mhansonp
added a commit
that referenced
this pull request
Mar 8, 2021
(cherry picked from commit 46f90a5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Reverting my test out due to presumed interactions with tests in the test class. Working on fixing and re-adding at a later date