GEODE-7864: Fix potential resource leak LGTM warnings #5582
Conversation
DonalEvans
force-pushed the
DonalEvans:feature/GEODE-7864
branch
2 times, most recently
from
1436671
to
12ba31b
DonalEvans
force-pushed the
DonalEvans:feature/GEODE-7864
branch
from
12ba31b
to
883804f
Authored-by: Donal Evans <doevans@vmware.com>
DonalEvans
force-pushed the
DonalEvans:feature/GEODE-7864
branch
from
883804f
to
f8fb3a4
|
This pull request fixes 108 alerts when merging f8fb3a4 into e85a1bd - view on LGTM.com fixed alerts:
|
...ava/org/apache/geode/management/internal/cli/commands/DeployCommand.java
Outdated
Show resolved
Hide resolved
|
Looks good! Just a couple comments, inline. For any other reviewers - it helps to use the github setting to ignore whitespaces changes. |
...main/java/org/apache/geode/distributed/internal/tcpserver/TcpClient.java
Outdated
Show resolved
Hide resolved
Authored-by: Donal Evans <doevans@vmware.com>
|
This pull request fixes 108 alerts when merging 5e5e94d into b167094 - view on LGTM.com fixed alerts:
|
mhansonp
added a commit
to mhansonp/geode
that referenced
this pull request
Oct 20, 2020
* GEODE-7864: Fix potential resource leak LGTM warnings Authored-by: Donal Evans <doevans@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Authored-by: Donal Evans doevans@vmware.com
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.