The Wayback Machine - https://web.archive.org/web/20220426074200/https://github.com/joomla/joomla-cms/issues/31540
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usability Issue in Joomla when filter text #31540

Open
B3nito opened this issue Nov 30, 2020 · 22 comments
Open

Usability Issue in Joomla when filter text #31540

B3nito opened this issue Nov 30, 2020 · 22 comments
Labels
good first issue No Code Attached Yet

Comments

@B3nito
Copy link

@B3nito B3nito commented Nov 30, 2020

Is your feature request related to a problem? Please describe.

When you are a enduser and use an editor and plugin settings is filtering input then html is just stripping out of text.

Describe the solution you'd like

User should get notification that html was cleaning for plugin settings so better usability

Additional context

I have problem in custom fields that filter is enabled default and user thought that Joomla is buggy. User should know what system is do automatically.

@HLeithner HLeithner added the good first issue label Jan 8, 2021
@Ayushsunny
Copy link

@Ayushsunny Ayushsunny commented Mar 18, 2021

Is this issue still persist?

@pank1999
Copy link

@pank1999 pank1999 commented Mar 19, 2021

i want to solve this issue please guide me

@Nitesh639
Copy link

@Nitesh639 Nitesh639 commented Mar 23, 2021

I want to solve this issue.

@Yash-g17
Copy link

@Yash-g17 Yash-g17 commented Mar 25, 2021

@HLeithner I'd love to work on this issue , can you please assign and guide me ?

@brianteeman
Copy link
Member

@brianteeman brianteeman commented Mar 25, 2021

The Joomla Project doesn't assign issues to contributors in that way. Just work on it and submit a PR :-)

https://github.com/joomla/joomla-cms/blob/staging/.github/CONTRIBUTING.md

@Ayushsunny
Copy link

@Ayushsunny Ayushsunny commented Mar 26, 2021

The Joomla Project doesn't assign issues to contributors in that way. Just work on it and submit a PR :-)

https://github.com/joomla/joomla-cms/blob/staging/.github/CONTRIBUTING.md

is there any mentor who can help us to solve this issue?

@abhijha0602
Copy link

@abhijha0602 abhijha0602 commented Mar 26, 2021

I want to solve this issue

@ghost
Copy link

@ghost ghost commented Mar 26, 2021

Just work on it and submit a PR :-)

@imtiyaj786
Copy link

@imtiyaj786 imtiyaj786 commented Mar 31, 2021

how can i check this issue in own ?

@ReLater
Copy link
Contributor

@ReLater ReLater commented Mar 31, 2021

Hello volunteers,

  • You don't have to ask if you are allowed to take over an issue.
    • Try to find a code solution for the issue after you have checked whether it really exists.
    • If it exists confirm it here in the issue for the sake of completeness. A "I'll take over" is a good hint for others that don't waste their time then with it.
    • Test your solution.
    • Finally provide a pull request on GitHub (= "here") that others can test. If tests are not successful you can change and discuss your pull request for further tests.
    • Sometimes others provide a "suggestion" that you can merge directly by clicking in your PR.
  • There are no mentors to accompany you. It goes without saying that you can ask the general public how this or that works. I think (don't know) that the "Discussions" tab above can be a good place for more general questions.
  • Here is a doc how to create pull requests via browser GUI: https://docs.joomla.org/Using_the_Github_UI_to_Make_Pull_Requests
  • If you want to go deeper you could also work with a git repository tool on your local machine. Needs some more skills and time to learn:
@amankothiyal04
Copy link

@amankothiyal04 amankothiyal04 commented Apr 4, 2021

hey @B3nito can you help me with this issue want to contribute to solve it

@Shaveetha
Copy link

@Shaveetha Shaveetha commented Apr 8, 2021

I would like to solve this issue. Can you please guide me.

@brianteeman
Copy link
Member

@brianteeman brianteeman commented Apr 8, 2021

@Shaveetha @amankothiyal04

Hello volunteers,

  • You don't have to ask if you are allowed to take over an issue.
    • Try to find a code solution for the issue after you have checked whether it really exists.
    • If it exists confirm it here in the issue for the sake of completeness. A "I'll take over" is a good hint for others that don't waste their time then with it.
    • Test your solution.
    • Finally provide a pull request on GitHub (= "here") that others can test. If tests are not successful you can change and discuss your pull request for further tests.
    • Sometimes others provide a "suggestion" that you can merge directly by clicking in your PR.
  • There are no mentors to accompany you. It goes without saying that you can ask the general public how this or that works. I think (don't know) that the "Discussions" tab above can be a good place for more general questions.
  • Here is a doc how to create pull requests via browser GUI: https://docs.joomla.org/Using_the_Github_UI_to_Make_Pull_Requests
  • If you want to go deeper you could also work with a git repository tool on your local machine. Needs some more skills and time to learn:
@brianteeman
Copy link
Member

@brianteeman brianteeman commented Apr 25, 2021

Can you please remove the "good first issue label" as its absolutely not a simple thing to fix (not sure if its even possible)

@HLeithner
Copy link
Member

@HLeithner HLeithner commented Apr 25, 2021

I don't think it's too hard.

I would solve this issue with 5 lines of code (without looking in deep, only looked at com_content)

Adding $original = $text at this position: https://github.com/joomla/joomla-cms/blob/4.0-dev/libraries/src/Component/ComponentHelper.php#L126

And a if ($text !== $original) { JFactory::getApplication()->enqueueMessage('JHTML_FILTER_MODIFY', CMSApplicationInterface::MSG_WARNING); } at line https://github.com/joomla/joomla-cms/blob/4.0-dev/libraries/src/Component/ComponentHelper.php#L295

Of course the language string have to be added too. But maybe I think too simple and missed something ymmv

@brianteeman
Copy link
Member

@brianteeman brianteeman commented Apr 25, 2021

  1. That won't work for text filtering where the editor eg tinymce is doing the filtering
  2. To be useful it really should say what has been filtered
@HLeithner
Copy link
Member

@HLeithner HLeithner commented Apr 25, 2021

  1. is not possible (at least I can't think of a working solution)

  2. I'm pretty sure there is a way to achieve this for tinymce in js too

@brianteeman
Copy link
Member

@brianteeman brianteeman commented Apr 25, 2021

Its still not a "good first issue" which was the point of my post

@HLeithner
Copy link
Member

@HLeithner HLeithner commented Apr 25, 2021

Why not? it's easy to fix, the first parts are only 5 lines of code.

What would you say what's a good first issue is, If you find one I would really like to tag it.

@brianteeman
Copy link
Member

@brianteeman brianteeman commented Apr 25, 2021

If it was so easy then any one of the 10 people who said they wanted to fix it would have been able to or anyone else for that matter in the months since november. plus if its really so easy then you would have submitted it instead of debating a pointless argument with me.

@teekhandekar
Copy link

@teekhandekar teekhandekar commented Mar 25, 2022

@brianteeman Can I work on this ?

@adithyareddych
Copy link

@adithyareddych adithyareddych commented Mar 28, 2022

@brianteeman Can I work on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue No Code Attached Yet