The Wayback Machine - https://web.archive.org/web/20210829060515/https://github.com/Kong/insomnia/issues/3150
Skip to content

/ insomnia

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Title Bar ignores dark mode #3150

Open
drocx opened this issue Mar 5, 2021 · 2 comments
Open

The Title Bar ignores dark mode #3150

drocx opened this issue Mar 5, 2021 · 2 comments
Labels
A-ui-ux E-good-first-issue

Comments

@drocx
Copy link

@drocx drocx commented Mar 5, 2021

Describe the bug
The Title Bar Color is white on Windows 10 with dark mode enabled.

To Reproduce
Steps to reproduce the behavior:

  1. Switch to windows dark mode
  2. Start Insomnia

Expected behavior
The Title Bar should use the dark mode like vs code or other electron apps.

Screenshots
image

Desktop (please complete the following information):

  • OS: Windows 10 20H2 Build 19042.844
  • App Version: 2021.1.0
@nijikokun
Copy link
Contributor

@nijikokun nijikokun commented Mar 5, 2021

This is definitely a good first issue for someone who wants to get into open source, looks like we are missing or overriding an electron setting:

const { nativeTheme } = require('electron')
nativeTheme.themeSource = 'system'
@dimitropoulos dimitropoulos mentioned this issue Mar 25, 2021
Closed
@roguib
Copy link
Contributor

@roguib roguib commented May 8, 2021

It seems, for this particular issue that nativeTheme.themeSource = 'system' doesn't change the color of the title bar in the current electron version of the project. It hasn't been until this PR was merged that the issue has been partially solved.

I've tried setting nativeTheme.themeSource = 'system' on different places suggested and it didn't change the color of the title bar to match the dark mode of the system. I've been researching a bit and it seems there're several workarounds to this issue such as implementing your custom title bar, use a complicated API to set the color of the bar or upgrade Electron.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ui-ux E-good-first-issue
3 participants
@nijikokun @drocx @roguib