The Wayback Machine - https://web.archive.org/web/20210129034344/https://github.com/nodejs/node/issues/36674
Skip to content

/ node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: pipeline should error if any stream is destroyed #36674

Open
ronag opened this issue Dec 29, 2020 · 1 comment · May be fixed by #36791
Open

stream: pipeline should error if any stream is destroyed #36674

ronag opened this issue Dec 29, 2020 · 1 comment · May be fixed by #36791
Labels
good first issue stream

Comments

@ronag
Copy link
Member

@ronag ronag commented Dec 29, 2020 •
edited

pipeline should immediately fail with ERR_STREAM_DESTROYED when any of the streams have already been destroyed.

Readable might need a little extra consideration since it's possible to read the data after being destroyed. Should maybe check _readableState.errored and/or _readableState.ended.

Refs: #29227 (comment)
@kalenikalexander
Copy link

@kalenikalexander kalenikalexander commented Dec 29, 2020

I would like to work on this problem
@kalenikalexander kalenikalexander mentioned this issue Jan 2, 2021
Open
kalenikalexander pushed a commit to kalenikalexander/node that referenced this issue Jan 4, 2021
kalenikalexander
streams: pipeline error if any stream is destroyed
b934636 
Fixes: nodejs#36674
Refs: nodejs#29227 (comment)
@kalenikalexander kalenikalexander linked a pull request that will close this issue Jan 4, 2021
Open
2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue stream
3 participants
@ronag @kalenikalexander and others