Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
fix: vendor node crawler from sane #10919
Merged
Conversation
| @@ -23,6 +23,7 @@ module.exports = { | |||
| modulePathIgnorePatterns: [ | |||
| 'examples/.*', | |||
| 'packages/.*/build', | |||
| 'packages/.*/tsconfig.*', | |||
SimenB
Dec 5, 2020
Author
Collaborator
noticed while debugging watch events
noticed while debugging watch events
SimenB
force-pushed the
SimenB:remove-sane
branch
3 times, most recently
from
76faf90
to
d4f488c
SimenB
merged commit 2b30d8b
into
facebook:master
23 of 25 checks passed
23 of 25 checks passed
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Summary
See #10048 for motivation - tl;dr
saneis unmaintained, so we should migrate away from it.Test plan
The watcher seems to work fine locally (macOS). Should be tested more extensively, tho. Advantage here over #10048 is that it's only the node watcher that changes. Disadvantage is that we vendor all the parts of
sanewe use...