The Wayback Machine - https://web.archive.org/web/20210208112745/https://github.com/obsproject/obs-studio/issues/4074
Skip to content

/ obs-studio

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paste (Duplicate/Reference) are clickable after removing copied source, but don't do anything #4074

Open
adriansuwala opened this issue Jan 15, 2021 · 2 comments · May be fixed by #4096
Open

Paste (Duplicate/Reference) are clickable after removing copied source, but don't do anything #4074

adriansuwala opened this issue Jan 15, 2021 · 2 comments · May be fixed by #4096
Labels
Confirmed Good first issue

Comments

@adriansuwala
Copy link

@adriansuwala adriansuwala commented Jan 15, 2021

Platform

Operating system and version: Windows 10 Build 19042, release: 2009, revision: 685, 64bit
OBS Studio version: 26.1.1

Expected Behavior

Either copied source is pasted or Paste (Duplicate) and Paste (Reference) options are not clickable

Current Behavior

Paste options are clickable but don't do anything

Steps to Reproduce

  1. Copy any source.
  2. Remove copied source.
  3. Right click -> Paste (Duplicate) or Paste (Reference)

Additional information

If pasting with other source focused (either in Sources pane or Preview), then sets that source's transform (even if it's locked) to that of copied source.
@ElectronicWar
Copy link
Collaborator

@ElectronicWar ElectronicWar commented Jan 15, 2021

Confirmed here but only when using "Copy (Duplicate)". When using a reference copy it still works (tested with Image source and browser source).
@WizardCM
Copy link
Collaborator

@WizardCM WizardCM commented Jan 15, 2021 •
edited

This'd be because when the item is copied, we just copy the name as a string, and don't check that the source still exists when opening the menu (only during paste). This should be a relatively easy issue to fix, but would need to be done in both Scenes & Sources, at the least. Possibly the audio mixer too.
@AlexanderBabansky AlexanderBabansky linked a pull request that will close this issue Jan 18, 2021
Open
2 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Confirmed Good first issue
3 participants
@WizardCM @ElectronicWar @adriansuwala