Emmet Expand Abbreviation should support expanding selection only #110901
Comments
|
I found another issue, when click [tab] on snippet tabstop wouldn't move to next tabstop instead trigger emmet expand (if Is this same problem? |
|
@t7yang does that issue still occur for you on the latest Insiders? I'm unable to reproduce it. If it does, can you paste an example abbreviation for me to use? |
|
@rzhao271 No, fixed now. |
|
@rzhao271 I am unable to repro this issue. I tried to do an explicit Emmet: expand abbreviation and it worked fine for me. Can you please confirm ? |
|
Oops!! I missed the first step in the repro - Have |
|
I found this piece of code in
Seems like when the setting @rzhao271 can you please help me understand why we have this check in place, as I am uanble to comprehend any scenario that needs this. |
|
Thanks for the update! |
|
This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation. Happy Coding! |
|
Thanks @rzhao271 . My only concern here is that for cases where we have |


Version: 1.52.0-insider (user setup)
Commit: 78908e7
Date: 2020-11-18T12:38:39.842Z
Electron: 9.3.3
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: 8.3.110.13-electron.0
OS: Windows_NT x64 10.0.19042
Steps to Reproduce:
emmet.triggerExpansionOnTabset to truetestdiv+spandiv+spanand explicitly run the commandEmmet: Expand AbbreviationDoes this issue occur when all extensions are disabled?: N/A
Also verified that this issue occurs on stable.
If the user merely presses tab, then the behaviour is understandable.
The confusing part is that the user is explicitly running the command, and a tab is inserted.
The text was updated successfully, but these errors were encountered: