The Wayback Machine - https://web.archive.org/web/20201218094126/https://github.com/seed-rs/seed/issues/505
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The list of missing common Ev, At or Tag #505

Open
MartinKavik opened this issue Jul 20, 2020 · 3 comments
Open

The list of missing common Ev, At or Tag #505

MartinKavik opened this issue Jul 20, 2020 · 3 comments

Comments

@L0g4n
Copy link

@L0g4n L0g4n commented Sep 16, 2020

I think data-target attribute is missing. I only found At::Data.

@MartinKavik
Copy link
Member Author

@MartinKavik MartinKavik commented Sep 16, 2020

I think data-target is a specific Bootstrap attribute that leverages data-* attributes (please correct me if I'm wrong).
Perhaps we can add a helper like At::data("xx", "yy") that generates data-xx="yy" in the future, but I don't think we should add specific data variants.

@L0g4n
Copy link

@L0g4n L0g4n commented Sep 16, 2020

I do not know about that, but other CSS frameworks are also using this attribute, e.g. Bulma: https://bulma.io/documentation/components/navbar/#basic-navbar
But now I see that the docs are strange. In the first example they are using data-target for the hamburger menu, then later they just omit that attribute.
Edit: I guess then it's not really required? 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.