The Wayback Machine - https://web.archive.org/web/20201212103321/https://github.com/pdpipe/pdpipe/issues/41
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea: add more linters to get more uniform codebase #41

Open
marcglobality opened this issue Oct 10, 2020 · 1 comment
Open

Idea: add more linters to get more uniform codebase #41

marcglobality opened this issue Oct 10, 2020 · 1 comment

Comments

@marcglobality
Copy link

@marcglobality marcglobality commented Oct 10, 2020

I'm using black and isort for other projects (see e.g. https://github.com/hyperopt/hyperopt/pull/748/files) and find them quite useful to have more consistent codebase. I think you should drop python3.5 support though, as black is python3.6+. Is this something you would be open to consider?

@shaypal5
Copy link
Collaborator

@shaypal5 shaypal5 commented Oct 20, 2020

I definitely would, as Python 3.5 end-of-life was this September, which means I'm consider dropping support for it as contributing to the community.

I've used black before. I just remember hating the way it refactored list and/or multi-line strings. I'm guessing this can be configured in a root-level, project wise, linter configuration file which we can add to the repository, which would be awesome.

Feel free to submit a PR moving us to this linter, but note it should include:

  1. Refactoring of the code using the linter (preferably black, since it has a string auto-formatting tools and commands).
  2. A linter configuration file in the root of the repository.
  3. Adding a test for linting problems as a separate job, which will fail on any linting problem (should be trivial; if the only command in the job is the call to the CLI command of the linter, the exit code is un-erroneous if there are no linting problems, which dictates the job fail/success state).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.