The Wayback Machine - https://web.archive.org/web/20200917081451/https://github.com/alibaba/spring-cloud-alibaba/issues/1681
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@Bean 方法签名是否需要统一命名规范 #1681

Open
PeineLiang opened this issue Sep 2, 2020 · 0 comments
Open

@Bean 方法签名是否需要统一命名规范 #1681

PeineLiang opened this issue Sep 2, 2020 · 0 comments
Assignees

Comments

@PeineLiang
Copy link

@PeineLiang PeineLiang commented Sep 2, 2020

Which Component

Describe what problem you have encountered

spring-cloud-alibaba中一些@bean方法的方法签名中有些是方法名与要导入的类名一致,有些是方法名与类名不一致的(风格不同的地方较多),这个是否需要统一一下,举例如下:

In the method signature of @bean method in spring-cloud-alibaba, some of the method names are consistent with the class names, and some are inconsistent with the class names. Here are some examples:

` @bean
public RocketMQTopicProvisioner provisioningProvider() {
return new RocketMQTopicProvisioner();
}

@Bean
public RocketMQMessageChannelBinder rocketMessageChannelBinder(
		RocketMQTopicProvisioner provisioningProvider,
		InstrumentationManager instrumentationManager) {
	RocketMQMessageChannelBinder binder = new RocketMQMessageChannelBinder(
			provisioningProvider, extendedBindingProperties,
			rocketBinderConfigurationProperties, rocketMQProperties,
			instrumentationManager);
	binder.setExtendedBindingProperties(extendedBindingProperties);
	return binder;
}

`
Describe what information you have read

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.