The Wayback Machine - https://web.archive.org/web/20220518233944/https://github.com/angular/components/pull/21909
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(google-maps): mapTypeId not being set from options #21909

Merged
merged 1 commit into from Feb 18, 2021
Merged

fix(google-maps): mapTypeId not being set from options #21909

merged 1 commit into from Feb 18, 2021

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Feb 15, 2021

Fixes a regression where the mapTypeId from the options object wasn't being preserved when combining the options with the input values.

Fixes #21903.

Note: setting as a P2, because it's a regression.
@crisbeto
fix(google-maps): mapTypeId not being set from options
c137397 
Fixes a regression where the `mapTypeId` from the `options` object wasn't being preserved
when combining the options with the input values.

Fixes angular#21903.
@crisbeto crisbeto added P2 target: patch labels Feb 15, 2021
@google-cla google-cla bot added the cla: yes label Feb 15, 2021
@crisbeto crisbeto added the merge ready label Feb 16, 2021
@andrewseguin andrewseguin merged commit 3f1b1f7 into angular:master Feb 18, 2021
16 checks passed
andrewseguin pushed a commit that referenced this issue Feb 18, 2021
@crisbeto @andrewseguin
fix(google-maps): mapTypeId not being set from options (#21909)
e227ebd 
Fixes a regression where the `mapTypeId` from the `options` object wasn't being preserved
when combining the options with the input values.

Fixes #21903.

(cherry picked from commit 3f1b1f7)
@dependabot dependabot bot mentioned this pull request Mar 6, 2021
Closed
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Mar 21, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.
@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes merge ready P2 target: patch
3 participants
@crisbeto @mbehrlich @andrewseguin