The Wayback Machine - https://web.archive.org/web/20211211000019/https://github.com/microsoft/vscode/pull/115241
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Playwright to v1.8.0. #115241

Merged
merged 2 commits into from Feb 2, 2021
Merged

Upgrade Playwright to v1.8.0. #115241

merged 2 commits into from Feb 2, 2021

Conversation

@MarcoZehe
Copy link
Contributor

@MarcoZehe MarcoZehe commented Jan 27, 2021

This enables VS Code to be built on ARM64 MacOS 11.2 and beyond. Fixes #115223.
@MarcoZehe
Upgrade Playwright to v1.8.0. This fixes Upgrade Playwright to 1.8.0 …
96077d9 
…to make VS Code build on ARM64 MacOS 11.2 and beyond microsoft#115223.
@deepak1556 deepak1556 requested a review from bpasero Jan 27, 2021
@deepak1556 deepak1556 added this to the February 2021 milestone Jan 27, 2021
@joaomoreno joaomoreno self-requested a review Jan 28, 2021
joaomoreno
joaomoreno requested changes Jan 28, 2021
View changes
Copy link
Member

@joaomoreno joaomoreno left a comment

@bpasero We can't accept PRs with changes on yarn.lock. If this is OK, run the yarn command locally yourself.
@MarcoZehe
Copy link
Contributor Author

@MarcoZehe MarcoZehe commented Feb 1, 2021

@bpasero We can't accept PRs with changes on yarn.lock. If this is OK, run the yarn command locally yourself.

Is there an action for me to take here, or are you taking over to sort out the correct yarn.lock file format/issue? The PR is open for maintainers to push to the branch.
@bpasero
Copy link
Member

@bpasero bpasero commented Feb 2, 2021

I suggest to update this PR and remove the yarn lock changes.
@MarcoZehe MarcoZehe requested review from joaomoreno and bpasero Feb 2, 2021
bpasero
bpasero approved these changes Feb 2, 2021
View changes
@joaomoreno joaomoreno assigned bpasero and unassigned joaomoreno Feb 2, 2021
@bpasero bpasero merged commit d503067 into microsoft:master Feb 2, 2021
5 of 6 checks passed
Loading
plainerman added a commit to plainerman/vscode that referenced this issue Feb 2, 2021
@MarcoZehe @plainerman
Upgrade Playwright to v1.8.0. (microsoft#115241)
a073d40 
* Upgrade Playwright to v1.8.0. This fixes Upgrade Playwright to 1.8.0 to make VS Code build on ARM64 MacOS 11.2 and beyond microsoft#115223.

* Revert changes to yarn.lock
MarcoZehe added a commit to MarcoZehe/vscode that referenced this issue Feb 3, 2021
@MarcoZehe @MarcoZehe
Upgrade Playwright to v1.8.0. (microsoft#115241)
00f7f35 
* Upgrade Playwright to v1.8.0. This fixes Upgrade Playwright to 1.8.0 to make VS Code build on ARM64 MacOS 11.2 and beyond microsoft#115223.

* Revert changes to yarn.lock
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
4 participants
@MarcoZehe @bpasero @joaomoreno @deepak1556