Handle normalized absolute file paths on markdown preview link click #116649
Conversation
| @@ -439,6 +439,9 @@ class MarkdownPreview extends Disposable implements WebviewResourceProvider { | |||
| if (hrefPath[0] !== '/') { | |||
| // Fix #93691, use this.resource.fsPath instead of this.resource.path | |||
| hrefPath = path.join(path.dirname(this.resource.fsPath), hrefPath); | |||
| } else { | |||
| // Handle any normalized file paths | |||
| hrefPath = hrefPath.replace('file///', ''); | |||
There was a problem hiding this comment.
After investigation, I noticed that this issue was caused inadvertently by https://github.com/microsoft/vscode/pull/114553/files where the links were normalised to display images. This fix handles both absolute links and file:/// links
There was a problem hiding this comment.
On windows, I think the file path will look like file://c/path/to/file. Try parsing the file path using vscode.Uri.parse and then getting the .fsPath from it instead. I think that should be safer but haven't tested
There was a problem hiding this comment.
Thanks for the suggestion. I've made the change The latest update now handles file:/ links as well. I've tested this change both on Windows and Mac for multiple paths.
Windows:
Mac:
| @@ -439,6 +439,9 @@ class MarkdownPreview extends Disposable implements WebviewResourceProvider { | |||
| if (hrefPath[0] !== '/') { | |||
| // Fix #93691, use this.resource.fsPath instead of this.resource.path | |||
| hrefPath = path.join(path.dirname(this.resource.fsPath), hrefPath); | |||
| } else { | |||
| // Handle any normalized file paths | |||
| hrefPath = hrefPath.replace('file///', ''); | |||
There was a problem hiding this comment.
On windows, I think the file path will look like file://c/path/to/file. Try parsing the file path using vscode.Uri.parse and then getting the .fsPath from it instead. I think that should be safer but haven't tested
|
Thanks! Will be in the next insiders build and is scheduled for VS Code 1.54 |
habibkarim
deleted the
habibkarim/115812_markdown_links_no_longer_work
branch
This PR fixes #115812