The Wayback Machine - https://web.archive.org/web/20210225040704/https://github.com/nextcloud/server/issues/25490
Skip to content

/ server

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing german translation - Settings of a share #25490

Open
blackerking opened this issue Feb 5, 2021 · 1 comment
Open

Missing german translation - Settings of a share #25490

blackerking opened this issue Feb 5, 2021 · 1 comment
Labels
1. to develop bug good first issue

Comments

@blackerking
Copy link

@blackerking blackerking commented Feb 5, 2021

Missing german translation if you change settings of share:
grafik
@blackerking blackerking added 0. Needs triage bug labels Feb 5, 2021
@kesselb kesselb added 1. to develop good first issue and removed 0. Needs triage labels Feb 5, 2021
@kesselb
Copy link
Contributor

@kesselb kesselb commented Feb 5, 2021

Code

server/lib/private/Share20/Manager.php

Line 545 in 6846a83

throw new \Exception('Sharing is only allowed with group members');

Example how to translate a exception message

server/lib/private/Share20/Manager.php

Lines 291 to 292 in 6846a83

$message_t = $this->l->t('You are not allowed to share %s', [$share->getNode()->getName()]);
throw new GenericShareException($message_t, $message_t, 404);

faust64 added a commit to Worteks/server that referenced this issue Feb 5, 2021
@faust64
fix(translation): replace static error message
Loading status checks…
59e43b4 
as suggested by @kesselb in nextcloud#25490

Signed-off-by: Samuel <faust64@gmail.com>
@faust64 faust64 mentioned this issue Feb 5, 2021
Merged
backportbot-nextcloud bot pushed a commit that referenced this issue Feb 5, 2021
@faust64 backportbot[bot]
fix(translation): replace static error message
038def2 
as suggested by @kesselb in #25490

Signed-off-by: Samuel <faust64@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop bug good first issue
2 participants
@blackerking @kesselb