camsaul
Follow
Pinned
2,508 contributions in the last year
Less
More
Contribution activity
February 2021
Created 33 commits in 5 repositories
Created a pull request in metabase/metabase that received 10 comments
Query results metadata should include field refs
#10474 stopped working because results metadata, which is used when we use an existing question as a saved question, didn't include field_ref info,…
+647
−511
•
10
comments
Opened 24 other pull requests in 1 repository
metabase/metabase
5
open
16
merged
3
closed
- Mongo DB: Massively simplify generated queries
- Optimize relative datetime filters
- Upgrade field literals
- Make Card PUT/POST endpoints sync instead of async
- Ignore source metadata for sources queries if missing 0.38.0+ field refs
- Fix using a query that contains joins to a table with FK remaps as a source query
- Relax restriction that sandboxes cannot add columns (ignore additional columns instead)
- Fix metadata for SQL-based sandboxes
- Fix 14724 [WIP]
- Make sure field refs returned by sandboxing middleware match non-sandboxed field refs
- Make sure resolve-joined-fields works on all levels (fixes #13642)
- Use log instead of printf/println for copy
- Tests: do "quick" sync for non-test-data datasets; shave MINUTES off of test runs
- Some CircleCI fixes
- Relax restriction that sandboxes cannot add columns (not sure if we need to merge)
- Show error messages in create/edit GTAP modal
- test helper fns data/rows/cols report clojure.test failures instead of throwing
- Unskip tests for 13642
- Make sure resolved-joined-fields deduplicates :fields
- Add ->$ids and ->query-shorthand test util macros
- Fix custom columns in pivot tables
- Convert hundreds of tests to the new style
- Collections tree API endpoint results should always return :children key
- CI: include sample-dataset.db.mv.db in frontend checksums
Reviewed 25 pull requests in 1 repository
metabase/metabase 25 pull requests
- Mongo DB: Massively simplify generated queries
- Extend the definition of sensitive-fields in the Database model to include any custom password type properties
- Use GitHub Actions to check for Dockerfile correctness
- Remove unused tool: colopocalypse
- Add JDBC fetch size option in driver
- Make Card PUT/POST endpoints sync instead of async
- Allow minutes and hours for dashboard relative date filter
- fix(rotate-encryption-key) settings-last-updated is not encrypted
- Update latest OSS on downloads.metabase.com
- Mb db connection uri parsing
- Split repro for #13641 in two versions: "remapped" and "default"
- Allow for `quick` parameter on `notify/db/:id` for quick syncing
- Update Dockerfile for parallel and 20% faster builds
- Update latest OSS on downloads.metabase.com
- Use GitHub Actions to run back-end linters
- #14612 Repro: Sandboxing limitations should have meaningful UI error message/feedback
- Turn off Cypress recording/parallel runs
- Split (SQL) repro for EE_520 in two versions
- add cmd rotate-encryption-key
- Log complete token validation error only to debug log
- Fix custom columns in pivot tables
- Skip repro for EE_520
- Convert hundreds of tests to the new style
- Allow SSL client certificates to work in pgsql
- Collections tree API endpoint results should always return :children key
Created an issue in metabase/metabase that received 3 comments
In Settings > Email, Save Changes is enabled even when there are no changes
In Settings > Email, Save Changes is enabled even when there are no changes, even after hitting save when no changes have been made… is this intent…
3
comments
Opened 21 other issues in 2 repositories
metabase/metabase
17
open
3
closed
- MongoDB shouldn't do an initial projection for :default date bucketing
- Fix unsuppressed log messages in metabase.automagic-dashboards.core-test
- Query optimizations for temporal filters
- Need better logic for waiting for a DB to be ready on CI
- Consolidate `data.cols` and `data.results_metadata.columns` in QP results
- Query Builder shouldn't use field-literal to refer to Fields from MBQL nested queries
- Can't load sample dataset into redshift
- Saved Questions search input is super jumpy
- Redirect after login is broken again
- Pivot queries aren't recorded to query execution log
- In Settings > Email, “Save changes” button doesn’t enable until onBlur event
- Left-hand nav sidebar changes size in admin panel
- Dashboard Subscriptions: Have to click the close button multiple times after viewing a Subscription
- Publish "latest" OSS JAR
- Proposal: consolidate different REST API error patterns or at least come up with consistent rules
- Clicking away from Sandbox modal breaks perms page
- Sandbox modal "cancel" doesn't work correctly
- Admin user last login date is in the future (timezone error)
- Data Model page busted if you visit a database that doesn't exist
- Keys in the :expressions map should be strings, not keywords
camsaul/methodical
1
open
9
contributions
in private repositories
Feb 1 – Feb 11