The Wayback Machine - https://web.archive.org/web/20210210085828/https://github.com/github/gitignore/pull/3066
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ignoring .ist files for glossaries-extra ... #3066

Merged
merged 1 commit into from May 22, 2019

Conversation

@Anton-Sakovich
Copy link
Contributor

@Anton-Sakovich Anton-Sakovich commented May 22, 2019

There has been an accepted pull request recently which added *.ist pattern to the bottom of the TeX.gitignore. I see two issues with this pull request:

  1. The major one: *.ist files are also custom style files for makeindex. Therefore, simply adding *.ist pattern under #glossaries-extra section can be misleading for those who use makeindex but not glossaries-extra. This problem is similar to the *.pdf problem. So, I suggest solving it the same way: let's add a commented line for *.ist files under #glossaries-extra section with an extended comment.

  2. The minor one: there is already #glossaries section in TeX.gitignore. I suggest moving *.ist pattern to this section for easier navigation.

package not interfere with makeindex's style files
@shiftkey
Copy link
Member

@shiftkey shiftkey commented May 22, 2019

cc @MohHizzani who submitted #3056 - do those changes make sense for you?

@MohHizzani
Copy link
Contributor

@MohHizzani MohHizzani commented May 22, 2019

glossaries-extra is a different package, but I thinks its okay to move it to glossary section, and yes it may cause a problem form who uses makeindex, but you comment it out

Anyway, these changes are good

@shiftkey
Copy link
Member

@shiftkey shiftkey commented May 22, 2019

@shiftkey shiftkey merged commit 6539838 into github:master May 22, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Ortega-Dan added a commit to Ortega-Dan/gitignore that referenced this pull request Jun 26, 2019
package not interfere with makeindex's style files
SaifurRahmanMohsin added a commit to SaifurRahmanMohsin/gitignore that referenced this pull request Jul 17, 2019
* upstream/master:
  Update Laravel.gitignore (github#3098)
  Ignore *.xyd outline files generated by xy LaTeX package (github#3088)
  Updating Joomla.gitignore to Joomla! 3.9.8 (github#3090)
  KiCAD: the -rescue.lib file is also precious! (github#3025)
  Revert "KiCad: add footprint cache (github#3043)" (github#3075)
  Add db.sqlite3-journal to Python.gitignore (github#3063)
  Make ignoring .ist files for glossaries-extra ... (github#3066)
r2pgl added a commit to r2pgl/gitignore that referenced this pull request Mar 15, 2020
package not interfere with makeindex's style files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants