The Wayback Machine - https://web.archive.org/web/20210209145946/https://github.com/twbs/bootstrap/pull/33017
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs on enforcing HTTPS and avoiding mixed content #33017

Merged
merged 2 commits into from Feb 9, 2021

Conversation

@philipkiely
Copy link
Contributor

@philipkiely philipkiely commented Feb 8, 2021

The live documentation requested that someone fill in the section on "Always use https"

This PR includes a short reference on why to use HTTPS for all sites.

It also includes a more relevant warning about mixed active content.

Both paragraphs link to authoritative, neutral third-party sources.

@mdo
mdo approved these changes Feb 9, 2021
Copy link
Member

@mdo mdo left a comment

I dig it! While it is outside the scope of the docs, maybe we can at least refer folks to Cloudflare or something as a starting point? Do they have a getting started guide we could link?

@philipkiely
Copy link
Contributor Author

@philipkiely philipkiely commented Feb 9, 2021

Thanks @mdo! Regarding a getting started guide, the thing is the range of potential hosts is so large that there wasn't a getting started guide that I felt good about referring to with confidence that it would cover a meaningful subset of users. If they're using GitHub Pages or Netlify they have totally different needs than Wordpress and different than AWS and so on.

If anyone else has a reference they like I can link it but I think overall users will have to find their own for whatever host they're using, and that's ok!

This is my first PR with Bootstrap, what is the process of getting it merged now that it's approved?

@XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Feb 9, 2021

I think further implementation details are outside of the scope of the guide. I mean, there are thousands of different services and software stacks.

I'd say we can merge this as is and expand it later.

@XhmikosR XhmikosR added docs v5 labels Feb 9, 2021
@XhmikosR XhmikosR added this to Inbox in v5.0.0-beta2 via automation Feb 9, 2021
@XhmikosR XhmikosR merged commit 96b86c1 into twbs:main Feb 9, 2021
13 checks passed
13 checks passed
bundlewatch
Details
css
Details
css
Details
Analyze
Details
docs
Details
Node 10
Details
lint
Details
Node 12
Details
Node 14
Details
LGTM analysis: JavaScript No code changes detected
Details
CodeQL No new or fixed alerts
Details
coverage/coveralls Coverage decreased (-0.06%) to 94.622%
Details
deploy/netlify Deploy preview ready!
Details
v5.0.0-beta2 automation moved this from Inbox to Done Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants