The Wayback Machine - https://web.archive.org/web/20201218090715/https://github.com/faker-ruby/faker/pull/2203
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback PR #2169 and bump 2.15.1 #2203

Merged
merged 3 commits into from Nov 25, 2020
Merged

Conversation

@vbrazo
Copy link
Member

@vbrazo vbrazo commented Nov 25, 2020

Issue#

Closes #2202

Description:

Rollback #2169 in order to fix issue in 2.15.0

@vbrazo vbrazo self-assigned this Nov 25, 2020
@vbrazo vbrazo changed the title Rollback PR #2169 Rollback PR #2169 and bump 2.15.1 Nov 25, 2020
@vbrazo vbrazo requested a review from faker-ruby/core-contributors Nov 25, 2020
@pond
pond approved these changes Nov 25, 2020
Copy link

@pond pond left a comment

Yep, looks good - definitely a welcome stopgap until we can figure out what was going wrong with #2169.

@vbrazo vbrazo merged commit 2b52e7a into master Nov 25, 2020
6 checks passed
6 checks passed
Rubocop
Details
Ruby 2.5
Details
Ruby 2.6
Details
Ruby 2.7
Details
Ruby head
Details
Ruby truffleruby-head
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.