The Wayback Machine - https://web.archive.org/web/20200715015555/https://github.com/reactioncommerce/reaction/issues/5152
Skip to content

/ reaction

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for async catalog functionByType #5152

Open
nnnnat opened this issue Apr 26, 2019 · 0 comments
Open

Add test for async catalog functionByType #5152

nnnnat opened this issue Apr 26, 2019 · 0 comments
Labels
enhancement good first issue help wanted

Comments

@nnnnat
Copy link
Member

@nnnnat nnnnat commented Apr 26, 2019

Prerequisites

  • Are you running the latest version?
  • Are you able to consistently reproduce the issue?
  • Did you search the issue queue for existing issue? Search issues

Issue Description

Recently we encountered an issue with several custom plugins all using the functionByType feature to extend the publishProductToCatalog function. When the catalog plugin would run these functionByType versions it would do so synchronously resulting in partial or duplicated catalog data at times. This issue was resolved with #5151 but we need to include some test to verify this is actually fixed and to catch it if we see it again.

Possible Solution

TBD
@nnnnat nnnnat added the testing label Apr 26, 2019
@nnnnat nnnnat mentioned this issue Apr 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue help wanted
2 participants
@nnnnat @aldeed
You can’t perform that action at this time.